8898 Commits (bd0a767eab5f4d4963bf12c05cb9b5a135172b14)

 

All Branches   

Search

Author	SHA1	Message	Date
Bruce Momjian	bd0a767eab	Here is a patch to make the current snapshot compile on Win32 (native, libpq ... and psql) again. Changes are: 1) psql requires the includes of "io.h" and "fcntl.h" in command.c in order to make a call to open() work (io.h for _open(), fcntl.h for the O_xxx) 2) PG_VERSION is no longer defined in version.h[.in], but in configure.in. Since we don't do configure on native win32, we need to put it in config.h.win32 :-( 3) Added define of SYSCONFDIR to config.h.win32 - libpq won't compile without it. This functionality is *NOT* tested - it's just defined as "" for now. May work, may not. 4) DEF_PGPORT renamed to DEF_PGPORT_STR I have done the "basic tests" on it - it connects to a database, and I can run queries. Haven't tested any of the fancier functions (yet). However, I stepped on a much bigger problem when fixing psql to work. It no longer works when linked against the .DLL version of libpq (which the Makefile does for it). I have left it linked against this version anyway, pending the comments I get on this mail :-) The problem is that there are strings being allocated from libpq.dll using PQExpBuffers (for example, initPQExpBuffer() on line 92 of input.c). These are being allocated using the malloc function used by libpq.dll. This function *may* be different from the malloc function used by psql.exe - only the resulting pointer must be valid. And with the default linking methods, it *WILL* be different. Later, psql.exe tries to free() this string, at which point it crashes because the free() function can't find the allocated block (it's on the allocated blocks list used by the runtime lib of libpq.dll). Shouldn't the right thing to do be to have psql call termPQExpBuffer() on the data instead? As it is now, gets_fromFile() will just return the pointer received from the PQExpBuffer.data (this may well be present at several places - this is the one I was bitten by so far). Isn't that kind of "accessing the internals of the PQExpBuffer structure" wrong? Instead, perhaps it shuold make a copy of the string, adn then termPQExpBuffer() it? In that case, the string will have been allocated from within the same library as the free() is called. I can get it to work just fine by doing this - changing from (around line 100 of input.c): and the same a bit further down in the same function. But, as I said above, this may be at more places in the code? Perhaps someone more familiar to it could comment on that? What do you think shuld be done about this? Personally, I go by the "If you allocate a piece of memory using an interface, use the same interface to free it", but the question is how to make it work :-) Also, AFAIK this only affects psql.exe, so the changes made to the libpq this patch are required no matter how the other issue is handled. Regards, Magnus	25 years ago
Bruce Momjian	a939e97451	Update	25 years ago
Bruce Momjian	2c591cb821	Add oid2name. Add streaming option later.	25 years ago
Hiroshi Inoue	a8b275e76d	Removed a dangerours DropRelationBuffers() call.	25 years ago
Tom Lane	997ee51631	Make functional index copy attstorage from the column data type, rather ... than forcing 'plain'. This probably does not matter right now, but I think it needs to be consistent with the regular (not-functional) index case, where attstorage is copied from the underlying table. Clean up some other dead and infelicitous code too.	25 years ago
Tom Lane	c654c69c05	Narrow scope of critical section, per discussion 1/19/01.	25 years ago
Tom Lane	4e27b308e2	Do _bt_wrtbuf() outside critical section, per discussion with Vadim 1/19.	25 years ago
Peter Eisentraut	d7157d32cb	The -R option didn't accept an argument, which made it kind of useless.	25 years ago
Tom Lane	f69ff0c4bd	Give 'a_expr ::= a_expr Op' production a slightly lower precedence than ... Op, so that the sequence 'a_expr Op Op a_expr' will be parsed as a_expr Op (Op a_expr) not (a_expr Op) Op a_expr as formerly. In other words, prefer treating user-defined operators as prefix operators to treating them as postfix operators, when there is an ambiguity. Also clean up a couple of other infelicities in production priority assignment --- for example, BETWEEN wasn't being given the intended priority, but that of AND.	25 years ago
Bruce Momjian	edfca4b98b	Subject: Bug in SQLForeignKeys() ... Query used for checking foreign key triggers returns too many results when there're more than one foreign key in a table. It happens because only table's oid is used to link between pg_trigger with INSERT check and pg_trigger with UPDATE/DELETE check. I think there should be enough to add following conditions into WHERE clause of that query: AND pt.tgconstrname = pg_trigger.tgconstrname AND pt.tgconstrname = pg_trigger_1.tgconstrname /Constantin	25 years ago
Peter Eisentraut	3de8407ea7	Remove useless leftover global variable Ps_status_buffer.	25 years ago
Bruce Momjian	6b3c8e3167	Add	25 years ago
Bruce Momjian	ab2c905152	Add email.	25 years ago
Bruce Momjian	04a843b249	Update TODO list.	25 years ago
Peter Mount	11cb9acb68	Some more additions to contrib for JDBC	25 years ago
Michael Meskes	d09fc12044	Moved database name handling to libecpg.	25 years ago
Tom Lane	786f1a59cd	Fix all the places that called heap_update() and heap_delete() without ... bothering to check the return value --- which meant that in case the update or delete failed because of a concurrent update, you'd not find out about it, except by observing later that the transaction produced the wrong outcome. There are now subroutines simple_heap_update and simple_heap_delete that should be used anyplace that you're not prepared to do the full nine yards of coping with concurrent updates. In practice, that seems to mean absolutely everywhere but the executor, because *noplace* else was checking.	25 years ago
Bruce Momjian	7a2a1acd52	Add	25 years ago
Bruce Momjian	56970c1bc0	Fix some int4->int32.	25 years ago
Tom Lane	b686fb5bf1	Remove no-longer-needed restriction against referencing system ... attributes in a FieldSelect node --- all the places that manipulate these work just fine with system attribute numbers. OK, it's a new feature, so shoot me ...	25 years ago
Bruce Momjian	e5cdecd01b	Update TODO list.	25 years ago
Bruce Momjian	7e533da492	Rename int4 to int32 in a few places.	25 years ago
Bruce Momjian	26aa69a2f6	Add threaded mention email.	25 years ago
Bruce Momjian	746d7e9145	Update TODO list.	25 years ago
Bruce Momjian	fc031fbe5c	Update FAQ.	25 years ago
Bruce Momjian	c805491792	Update FAQ.	25 years ago
Tom Lane	728b0aa290	Improve realloc() per idea from Karel Zak --- if chunk to be enlarged is ... at end of its block, maybe we can enlarge it in-place.	25 years ago
Bruce Momjian	c0bb21b369	Update FAQ.	25 years ago
Bruce Momjian	d90703aaf2	Update TODO list.	25 years ago
Bruce Momjian	18f45e9aed	Update TODO list.	25 years ago
Bruce Momjian	f60e4347a8	Update TODO list.	25 years ago
Peter Eisentraut	21a3857f1f	Rip out table expression section from SQL syntax chapter and develop it ... into new chapter on query (SELECT) syntax. In the end this should become a narrative and example-filled counterpart to the SELECT reference page.	25 years ago
Tom Lane	e9c936ff38	Remove rangechecks on errno; just call strerror unconditionally. This ... eliminates a raft of portability issues, including whether sys_nerr exists, whether the platform has any valid negative errnos, etc. The downside is minimal: errno shouldn't ever contain an invalid value anyway, and if it does, reasonably modern versions of strerror will not choke. This rangecheck idea seemed good at the time, but it's clearly a net loss, and I apologize to all concerned for having ever put it in.	25 years ago
Bruce Momjian	60b282fd26	Put back old MS FAQ>	25 years ago
Tom Lane	e84c429062	Clean up lockmanager data structures some more, in preparation for planned ... rewrite of deadlock checking. Lock holder objects are now reachable from the associated LOCK as well as from the owning PROC. This makes it practical to find all the processes holding a lock, as well as all those waiting on the lock. Also, clean up some of the grottier aspects of the SHMQueue API, and cause the waitProcs list to be stored in the intuitive direction instead of the nonintuitive one. (Bet you didn't know that the code followed the 'prev' link to get to the next waiting process, instead of the 'next' link. It doesn't do that anymore.)	25 years ago
Bruce Momjian	56f5f2bf82	Update FAQ.	25 years ago
Michael Meskes	88ce6a2ba0	Synced preproc.y with gram.y and added missing include file to pgc.l.	25 years ago
Bruce Momjian	0fada37f5d	Update FAQ.	25 years ago
Tom Lane	7e0919136a	Minor fixes.	25 years ago
Bruce Momjian	505cdd5873	Update FAQ.	25 years ago
Bruce Momjian	5f93794f1e	Update FAQ.	25 years ago
Bruce Momjian	64b3af90f1	Add.	25 years ago
Bruce Momjian	ede3d259fc	Update.	25 years ago
Bruce Momjian	bf01c7983b	Make Kevin Lo's MS FAQ the default.	25 years ago
Tom Lane	c9fe128316	Clean up per-tuple memory leaks in trigger firing and plpgsql ... expression evaluation.	25 years ago
Tom Lane	59a3a40149	All the global memory contexts should be DLLIMPORT, if any are.	25 years ago
Bruce Momjian	d90eb434e4	Update FAQ.	25 years ago
Peter Eisentraut	4f34f55d3d	Description of table expressions, including join syntax, from Robert B. ... Easter <reaster@comptechnews.com>, heavily massaged by me. Also cleaned up value expressions a bit.	25 years ago
Bruce Momjian	d7d51bc138	Put quotes around environment variables.	25 years ago
Bruce Momjian	11d9d2cfaa	Update FAQ.	25 years ago