You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Bruce Momjian 440953e6cd Tom, happier with the attached patch? ... I'd have to disagree with regards to the memory leaks not being worth a mention - any such leak can cause problems when the PostgreSQL installation is either unattended, long-living andor has very high connection levels. Half a kilobyte on start-up isn't negligible in this light. Regards, Lee. Tom Lane writes: > Lee Kindness <lkindness@csl.co.uk> writes: > > Guys, attached is a patch to fix two memory leaks on start-up. > > I do not like the changes to miscinit.c. In the first place, it is not > a "memory leak" to do a one-time allocation of state for a proc_exit > function. A bigger complaint is that your proposed change introduces > fragile coupling between CreateLockFile and its callers, in order to > save no resources worth mentioning. More, it introduces an assumption > that the globals directoryLockFile and socketLockFile don't change while > the postmaster is running. UnlinkLockFile should unlink the file that > it was originally told to unlink, regardless of what happens to those > globals. > > If you are intent on spending code to free stuff just before the > postmaster exits, a better fix would be for UnlinkLockFile to free its > string argument after using it. Lee Kindness		23 years ago
..
access	Error message editing in backend/access.	23 years ago
bootstrap	Error message editing in backend/bootstrap, /lib, /nodes, /port.	23 years ago
catalog	Error message editing in backend/catalog.	23 years ago
commands	Error message editing in backend/libpq, backend/postmaster, backend/tcop.	23 years ago
executor	Error message editing in backend/executor.	23 years ago
lib	Error message editing in backend/bootstrap, /lib, /nodes, /port.	23 years ago
libpq	Have SSL text print only when SSL mode is enabled.	23 years ago
main	Add --help-config facility to dump information about GUC parameters	23 years ago
nodes	Error message editing in backend/bootstrap, /lib, /nodes, /port.	23 years ago
optimizer	Error message editing in backend/optimizer, backend/rewrite.	23 years ago
parser	Another round of error message editing, covering backend/commands/.	23 years ago
po	Add missing PO files from last commit.	23 years ago
port	Error message editing in backend/bootstrap, /lib, /nodes, /port.	23 years ago
postmaster	Have a go at fixing various outstanding portability issues in code that	23 years ago
regex	Replace regular expression package with Henry Spencer's latest version	23 years ago
rewrite	Error message editing in backend/optimizer, backend/rewrite.	23 years ago
storage	Error message editing in backend/storage.	23 years ago
tcop	Error message editing in backend/libpq, backend/postmaster, backend/tcop.	23 years ago
utils	Tom, happier with the attached patch?	23 years ago
Makefile	Make "win" a separate port from "cygwin". This means you can now	23 years ago
nls.mk	Add ereport-related functions to GETTEXT_TRIGGERS list.	23 years ago