You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Amit Kapila d65485b02b Fix xmin advancement during fast_forward decoding. ... During logical decoding, we advance catalog_xmin of logical too early in fast_forward mode, resulting in required catalog data being removed by vacuum. This mode is normally used to advance the slot without processing the changes, but we still can't let the slot's xmin to advance to an incorrect value. Commit f49a80c481 fixed a similar issue where the logical slot's catalog_xmin was getting advanced prematurely during non-fast-forward mode. During xl_running_xacts processing, instead of directly advancing the slot's xmin to the oldest running xid in the record, it allowed the xmin to be held back for snapshots that can be used for not-yet-replayed transactions, as those might consider older txns as running too. However, it missed the fact that the same problem can happen during fast_forward mode decoding, as we won't build a base snapshot in that mode, and the future call to get_changes from the same slot can miss seeing the required catalog changes leading to incorrect reslts. This commit allows building the base snapshot even in fast_forward mode to prevent the early advancement of xmin. Reported-by: Amit Kapila <amit.kapila16@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/CAA4eK1LqWncUOqKijiafe+Ypt1gQAQRjctKLMY953J79xDBgAg@mail.gmail.com Discussion: https://postgr.es/m/OS0PR01MB57163087F86621D44D9A72BF94BB2@OS0PR01MB5716.jpnprd01.prod.outlook.com		5 months ago
..
binary.out	Message style improvements	10 years ago
catalog_change_snapshot.out	Fix assertion failures while processing NEW_CID record in logical decoding.	3 years ago
concurrent_ddl_dml.out	Improve display of query results in isolation tests.	4 years ago
ddl.out	Introduce xid8-based functions to replace txid_XXX.	6 years ago
decoding_in_xact.out	Introduce xid8-based functions to replace txid_XXX.	6 years ago
decoding_into_rel.out	Fix crash when logical decoding is invoked from a PL function.	8 years ago
delayed_startup.out	Improve display of query results in isolation tests.	4 years ago
invalidation_distribution.out	Fix typo in test file name added in commit 4909b38af0.	5 months ago
messages.out	Add required database and origin filtering for logical messages.	10 years ago
mxact.out	Improve display of query results in isolation tests.	4 years ago
oldest_xmin.out	Fix xmin advancement during fast_forward decoding.	5 months ago
ondisk_startup.out	Improve display of query results in isolation tests.	4 years ago
permissions.out	Replace AclObjectKind with ObjectType	8 years ago
prepared.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
replorigin.out	Remove assertion for replication origins in PREPARE TRANSACTION	4 years ago
rewrite.out	Fix regression tests to use only global names beginning with "regress_".	6 years ago
skip_snapshot_restore.out	Fix possibility of logical decoding partial transaction changes.	1 year ago
slot.out	Check slot->restart_lsn validity in a few more places	5 years ago
snapshot_transfer.out	Improve display of query results in isolation tests.	4 years ago
spill.out	Make contrib/test_decoding regression tests safe for CZ locale.	9 years ago
subxact_without_top.out	Improve display of query results in isolation tests.	4 years ago
time.out	logical decoding: fix decoding of a commit's commit time.	10 years ago
toast.out	WAL log unchanged toasted replica identity key attributes.	4 years ago
truncate.out	Force synchronous commit to be enabled for all test_decoding tests.	7 years ago
xact.out	Don't propagate a null subtransaction snapshot up to parent transaction.	9 years ago