You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Amit Kapila ff787dd9e3 Fix xmin advancement during fast_forward decoding. ... During logical decoding, we advance catalog_xmin of logical too early in fast_forward mode, resulting in required catalog data being removed by vacuum. This mode is normally used to advance the slot without processing the changes, but we still can't let the slot's xmin to advance to an incorrect value. Commit f49a80c481 fixed a similar issue where the logical slot's catalog_xmin was getting advanced prematurely during non-fast-forward mode. During xl_running_xacts processing, instead of directly advancing the slot's xmin to the oldest running xid in the record, it allowed the xmin to be held back for snapshots that can be used for not-yet-replayed transactions, as those might consider older txns as running too. However, it missed the fact that the same problem can happen during fast_forward mode decoding, as we won't build a base snapshot in that mode, and the future call to get_changes from the same slot can miss seeing the required catalog changes leading to incorrect reslts. This commit allows building the base snapshot even in fast_forward mode to prevent the early advancement of xmin. Reported-by: Amit Kapila <amit.kapila16@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/CAA4eK1LqWncUOqKijiafe+Ypt1gQAQRjctKLMY953J79xDBgAg@mail.gmail.com Discussion: https://postgr.es/m/OS0PR01MB57163087F86621D44D9A72BF94BB2@OS0PR01MB5716.jpnprd01.prod.outlook.com		4 months ago
..
binary.out	…
catalog_change_snapshot.out	…
concurrent_ddl_dml.out	…
concurrent_stream.out	Remove incidental md5() function uses from several tests	2 years ago
ddl.out	Revert structural changes to not-null constraints	1 year ago
decoding_in_xact.out	Make RelationFlushRelation() work without ResourceOwner during abort	1 year ago
decoding_into_rel.out	…
delayed_startup.out	…
invalidation_distribution.out	Fix typo in test file name added in commit 4909b38af0.	4 months ago
messages.out	Add flush option to pg_logical_emit_message()	2 years ago
mxact.out	…
oldest_xmin.out	Fix xmin advancement during fast_forward decoding.	4 months ago
ondisk_startup.out	…
permissions.out	Add a slot synchronization function.	2 years ago
prepared.out	…
replorigin.out	Fix the misuse of origin filter across multiple pg_logical_slot_get_changes() calls.	2 years ago
rewrite.out	…
skip_snapshot_restore.out	Fix possibility of logical decoding partial transaction changes.	1 year ago
slot.out	Revise GUC names quoting in messages again	1 year ago
slot_creation_error.out	…
snapshot_transfer.out	…
spill.out	…
stats.out	…
stream.out	Stabilize the test added by commit 022564f60c.	10 months ago
subxact_without_top.out	…
time.out	…
toast.out	…
truncate.out	…
twophase.out	Stabilize the test added by commit 022564f60c.	10 months ago
twophase_snapshot.out	…
twophase_stream.out	Add STREAM_START/STREAM_STOP for transactional messages during decoding.	2 years ago
xact.out	…