You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane f002ed2b8e Improve error reporting in pg_upgrade's file copying/linking/rewriting. ... The previous design for this had copyFile(), linkFile(), and rewriteVisibilityMap() returning strerror strings, with the caller producing one-size-fits-all error messages based on that. This made it impossible to produce messages that described the failures with any degree of precision, especially not short-read problems since those don't set errno at all. Since pg_upgrade has no intention of continuing after any error in this area, let's fix this by just letting these functions call pg_fatal() for themselves, making it easy for each point of failure to have a suitable error message. Taking this approach also allows dropping cleanup code that was unnecessary and was often rather sloppy about preserving errno. To not lose relevant info that was reported before, pass in the schema name and table name of the current table so that they can be included in the error reports. An additional problem was the use of getErrorText(), which was flat out wrong for all but a couple of call sites, because it unconditionally did "_dosmaperr(GetLastError())" on Windows. That's only appropriate when reporting an error from a Windows-native API, which only a couple of the callers were actually doing. Thus, even the reported strerror string would be unrelated to the actual failure in many cases on Windows. To fix, get rid of getErrorText() altogether, and just have call sites do strerror(errno) instead, since that's the way all the rest of our frontend programs do it. Add back the _dosmaperr() calls in the two places where that's actually appropriate. In passing, make assorted messages hew more closely to project style guidelines, notably by removing initial capitals in not-complete-sentence primary error messages. (I didn't make any effort to clean up places I didn't have another reason to touch, though.) Per discussion of a report from Thomas Kellerer. Back-patch to 9.6, but no further; given the relative infrequency of reports of problems here, it's not clear it's worth adapting the patch to older branches. Patch by me, but with credit to Alvaro Herrera for spotting the issue with getErrorText's misuse of _dosmaperr(). Discussion: <nsjrbh$8li$1@blaine.gmane.org>		10 years ago
..
backend	Silence compiler warnings	10 years ago
bin	Improve error reporting in pg_upgrade's file copying/linking/rewriting.	10 years ago
common	Fix compiler warnings	10 years ago
fe_utils	Teach appendShellString() to not quote strings containing "-".	10 years ago
include	Fix breakage in previous change	10 years ago
interfaces	Refer to OS X as "macOS", except for the port name which is still "darwin".	10 years ago
makefiles	…
pl	Improve parser's and planner's handling of set-returning functions.	10 years ago
port	Include <sys/select.h> where needed	10 years ago
template	Refer to OS X as "macOS", except for the port name which is still "darwin".	10 years ago
test	Switch pg_basebackup commands in Postgres.pm to use --nosync	10 years ago
timezone	Add regression test coverage for non-default timezone abbreviation sets.	10 years ago
tools	Move fsync routines of initdb into src/common/	10 years ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	Install TAP test infrastructure so it's available for extension testing.	10 years ago
Makefile.global.in	Provide and use a makefile target to build all generated headers.	10 years ago
Makefile.shlib	Refer to OS X as "macOS", except for the port name which is still "darwin".	10 years ago
bcc32.mak	…
nls-global.mk	nls-global.mk: search build dir for source files, too	10 years ago
win32.mak	…