23954 Commits (3a569c80302d42aeb64ff66ed270e58439fa663f)

 

All Branches   

Search

Author	SHA1	Message	Date
dlamarcheteamnet	3a569c8030	add event_id in return do_3pid_invite	1 year ago
dlamarcheteamnet	efc6ace1b1	debug invit	1 year ago
dlamarcheteamnet	142020a6f9	debug invit	1 year ago
dlamarcheteamnet	6c49551346	debug invit	1 year ago
dlamarcheteamnet	44f41d8537	rm check id_acces_token	1 year ago
dlamarcheteamnet	526886c839	debug new DM	1 year ago
dlamarcheteamnet	58c3d9492d	debug new DM	1 year ago
dlamarcheteamnet	01924e1dbf	debug new DM	1 year ago
dlamarcheteamnet	dd05b05913	acces token	1 year ago
dlamarcheteamnet	2a6e961289	54 -> 72	1 year ago
dlamarcheteamnet	24baa2e569	72 -> 54	1 year ago
DevSymbioide	d92e2cc7e7	comments watcha	1 year ago
DevSymbioide	9964d9931d	replace localpart to user_id	1 year ago
DevSymbioide	0165de5d84	send UserID in get_profileinfo watcha_registration	1 year ago
DevSymbioide	b824696cda	rm check id_access_token	1 year ago
DevSymbioide	bf149352d6	debug	2 years ago
DevSymbioide	70c30a3fb0	id_access_token optional	2 years ago
dlamarcheteamnet	bf344ee3fd	debug	2 years ago
dlamarcheteamnet	dc93bc0105	change error message 3pid invite	2 years ago
dlamarcheteamnet	8104b494a8	send Requester to get_user_role	2 years ago
dlamarcheteamnet	98a56cf408	send Requester to check_user_in_room from watcha_nextcloud	2 years ago
dlamarcheteamnet	ec2ccc606e	rm auth.py	2 years ago
dlamarcheteamnet	f7e651d772	remove last ','	2 years ago
dlamarcheteamnet	2d1bc912d8	modify registation	2 years ago
dlamarcheteamnet	7a6da4d87f	modify change_password	2 years ago
dlamarcheteamnet	1fb434fc05	deltas min54	2 years ago
dlamarcheteamnet	d8b97e0af5	assigne event_dict before reference	2 years ago
dlamarcheteamnet	1e924a5468	add comment #watcha	2 years ago
dlamarcheteamnet	ee020615bf	add is_partner in get_user_by_id	2 years ago
dlamarcheteamnet	a715b8c6ff	add is_partner in row and return in _query_for_auth	2 years ago
dlamarcheteamnet	7b6bbcac8a	add allow_locked in _wrapped_get_user_by_req	2 years ago
dlamarcheteamnet	ec63f5a8bd	remove thirdpid from watcha_registration	2 years ago
dlamarcheteamnet	35f7201193	Remove ThreepidBehaviour from watcha files	2 years ago
dlamarcheteamnet	4421b4f0e5	séparation auth	2 years ago
dlamarcheteamnet	eff5ada386	merge	2 years ago
dlamarcheteamnet	17bf603d3e	No significant changes since 1.103.0rc1. ... - Add a new [List Accounts v3](https://element-hq.github.io/synapse/v1.103/admin_api/user_admin_api.html#list-accounts-v3) Admin API with improved deactivated user filtering capabilities. ([\#16874](https://github.com/element-hq/synapse/issues/16874)) - Include `Retry-After` header by default per [MSC4041](https://github.com/matrix-org/matrix-spec-proposals/pull/4041). Contributed by @clokep. ([\#16947](https://github.com/element-hq/synapse/issues/16947)) - Fix joining remote rooms when a module uses the `on_new_event` callback. This callback may now pass partial state events instead of the full state for remote rooms. Introduced in v1.76.0. ([\#16973](https://github.com/element-hq/synapse/issues/16973)) - Fix performance issue when joining very large rooms that can cause the server to lock up. Introduced in v1.100.0. Contributed by @ggogel. ([\#16968](https://github.com/element-hq/synapse/issues/16968)) - Add HAProxy example for single port operation to reverse proxy documentation. Contributed by Georg Pfuetzenreuter (@tacerus). ([\#16768](https://github.com/element-hq/synapse/issues/16768)) - Improve the documentation around running Complement tests with new configuration parameters. ([\#16946](https://github.com/element-hq/synapse/issues/16946)) - Add docs on upgrading from a very old version. ([\#16951](https://github.com/element-hq/synapse/issues/16951)) * Bump JasonEtco/create-an-issue from 2.9.1 to 2.9.2. ([\#16934](https://github.com/element-hq/synapse/issues/16934)) * Bump anyhow from 1.0.79 to 1.0.80. ([\#16935](https://github.com/element-hq/synapse/issues/16935)) * Bump dawidd6/action-download-artifact from 3.0.0 to 3.1.1. ([\#16933](https://github.com/element-hq/synapse/issues/16933)) * Bump furo from 2023.9.10 to 2024.1.29. ([\#16939](https://github.com/element-hq/synapse/issues/16939)) * Bump pyopenssl from 23.3.0 to 24.0.0. ([\#16937](https://github.com/element-hq/synapse/issues/16937)) * Bump types-netaddr from 0.10.0.20240106 to 1.2.0.20240219. ([\#16938](https://github.com/element-hq/synapse/issues/16938)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmX5hKkACgkQLS76LzL7 4EfPKBAAu9Vr7gsYZhgXrYWc+xkInJY4BUbQZcD6B3mSAVS1SbUkqiIhFHR5A7su jC9iPglmRDu6FRMA0i0l4icMIwYGPqzrWwATDA+mxrfxcaPUwZYXzM4FgyI+E+ht 7Wkrd2KLJ5Ag9Jk4bTmols/6Np4b6UwfCALJ8KWbaQn4TaoO5bmTVCnfuvwd+39V KPo8QaZWdqk67lUn+aq/GKRxhik7Yzk6GA7W+i0a7qq81+UM1WWcNnFR4Hh1Qf9M 6cacTOBHkdwl4wAcZ3OkN4JVzm5dm2t/qtScA0e8zr5W6eT+HzNHJFxEPrY7Jpk9 9SPHEA7vdU6sX69PH4eKE3olW/1pA/HHFOFtl6gIeE9C17j2h+7nBLqryaj/UH7S Ar+n6B/AmVhxCQxdbopt4ucxirWgoP9YQ/O8kqH2NnHUMkWIp1zkqpHd5Pd7E23v pM0+5MyJVAyBqtN0jjgYp07lzaWE7xpmR7b54sSiznobCQ6g1pd/Mmg9WQENweVF gB9DZO8Rs25q0sjRjRJOmteJGaqtw5Cdt7poFcpTg79BfH69dtFXZ2jpTB+kna7U GEjcK2reIjKDwuv1XvgDxfUW9knqjMeRO46KHTdRQpKJAvZNoL2tsnzqIvbT6xTV Teu6wNPenioG72kjfiAvaQIb4URSwhlaL9Yb2tH9mOHgiXuoPkQ= =A2Zh -----END PGP SIGNATURE----- Merge branch 'element-synapse-1.103.0' into code_spécifique_watcha	2 years ago
Olivier Wilkinson (reivilibre)	0b4dc4de7c	1.103.0	2 years ago
Erik Johnston	5c0b87ff95	Update changelog	2 years ago
Erik Johnston	0d44f64c4e	Merge remote-tracking branch 'origin/develop' into release-v1.103	2 years ago
Gerrit Gogel	1f88790764	Prevent locking up while processing batched_auth_events (#16968) ... This PR aims to fix #16895, caused by a regression in #7 and not fixed by #16903. The PR #16903 only fixes a starvation issue, where the CPU isn't released. There is a second issue, where the execution is blocked. This theory is supported by the flame graphs provided in #16895 and the fact that I see the CPU usage reducing and far below the limit. Since the changes in #7, the method `check_state_independent_auth_rules` is called with the additional parameter `batched_auth_events`: 6fa13b4f92/synapse/handlers/federation_event.py (L1741-L1743) It makes the execution enter this if clause, introduced with #15195 6fa13b4f92/synapse/event_auth.py (L178-L189) There are two issues in the above code snippet. First, there is the blocking issue. I'm not entirely sure if this is a deadlock, starvation, or something different. In the beginning, I thought the copy operation was responsible. It wasn't. Then I investigated the nested `store.get_events` inside the function `update`. This was also not causing the blocking issue. Only when I replaced the set difference operation (`-` ) with a list comprehension, the blocking was resolved. Creating and comparing sets with a very large amount of events seems to be problematic. This is how the flamegraph looks now while persisting outliers. As you can see, the execution no longer locks up in the above function.  Second, the copying here doesn't serve any purpose, because only a shallow copy is created. This means the same objects from the original dict are referenced. This fails the intention of protecting these objects from mutation. The review of the original PR https://github.com/matrix-org/synapse/pull/15195 had an extensive discussion about this matter. Various approaches to copying the auth_events were attempted: 1) Implementing a deepcopy caused issues due to builtins.EventInternalMetadata not being pickleable. 2) Creating a dict with new objects akin to a deepcopy. 3) Creating a dict with new objects containing only necessary attributes. Concluding, there is no easy way to create an actual copy of the objects. Opting for a deepcopy can significantly strain memory and CPU resources, making it an inefficient choice. I don't see why the copy is necessary in the first place. Therefore I'm proposing to remove it altogether. After these changes, I was able to successfully join these rooms, without the main worker locking up: - #synapse:matrix.org - #element-android:matrix.org - #element-web:matrix.org - #ecips:matrix.org - #ipfs-chatter:ipfs.io - #python:matrix.org - #matrix:matrix.org	2 years ago
Erik Johnston	9d7880c0c6	1.103.0rc1	2 years ago
Alexander Fechler	48f59d3806	deactivated flag refactored to filter deactivated users. (#16874) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2 years ago
Patrick Cloke	696cc9e802	Stabilize support for Retry-After header (MSC4014) (#16947)	2 years ago
Quentin Gliech	4af33015af	Fix joining remote rooms when a `on_new_event` callback is registered (#16973) ... Since Synapse 1.76.0, any module which registers a `on_new_event` callback would brick the ability to join remote rooms. This is because this callback tried to get the full state of the room, which would end up in a deadlock. Related: https://github.com/matrix-org/synapse-auto-accept-invite/issues/18 The following module would brick the ability to join remote rooms: ```python from typing import Any, Dict, Literal, Union import logging from synapse.module_api import ModuleApi, EventBase logger = logging.getLogger(__name__) class MyModule: def __init__(self, config: None, api: ModuleApi): self._api = api self._config = config self._api.register_third_party_rules_callbacks( on_new_event=self.on_new_event, ) async def on_new_event(self, event: EventBase, _state_map: Any) -> None: logger.info(f"Received new event: {event}") @staticmethod def parse_config(_config: Dict[str, Any]) -> None: return None ``` This is technically a breaking change, as we are now passing partial state on the `on_new_event` callback. However, this callback was broken for federated rooms since 1.76.0, and local rooms have full state anyway, so it's unlikely that it would change anything.	2 years ago
Andrew Morgan	2d1bb0b06b	Merge remote-tracking branch 'origin/release-v1.102' into develop	2 years ago
Andrew Morgan	ab80b3412e	Revert "Ignore notification counts from rooms you've left" (#16981)	2 years ago
Andrew Morgan	1dee1b72ec	Switch #16979 changelog type from internal change to bugfix	2 years ago
Andrew Morgan	571ca0c004	1.102.0	2 years ago
Andrew Morgan	8a05304222	Revert "Improve DB performance of calculating badge counts for push. (#16756)" (#16979)	2 years ago
Andrew Morgan	274f289a52	Ignore notification counts from rooms you've left (#16954) ... Co-authored-by: reivilibre <oliverw@matrix.org>	2 years ago