16182 Commits (3a569c80302d42aeb64ff66ed270e58439fa663f)

Author	SHA1	Message	Date
dlamarcheteamnet	3a569c8030	add event_id in return do_3pid_invite	2 weeks ago
dlamarcheteamnet	efc6ace1b1	debug invit	1 month ago
dlamarcheteamnet	142020a6f9	debug invit	1 month ago
dlamarcheteamnet	6c49551346	debug invit	1 month ago
dlamarcheteamnet	44f41d8537	rm check id_acces_token	1 month ago
dlamarcheteamnet	526886c839	debug new DM	1 month ago
dlamarcheteamnet	58c3d9492d	debug new DM	1 month ago
dlamarcheteamnet	01924e1dbf	debug new DM	1 month ago
dlamarcheteamnet	dd05b05913	acces token	5 months ago
dlamarcheteamnet	2a6e961289	54 -> 72	5 months ago
dlamarcheteamnet	24baa2e569	72 -> 54	5 months ago
DevSymbioide	d92e2cc7e7	comments watcha	6 months ago
DevSymbioide	9964d9931d	replace localpart to user_id	6 months ago
DevSymbioide	0165de5d84	send UserID in get_profileinfo watcha_registration	6 months ago
DevSymbioide	b824696cda	rm check id_access_token	6 months ago
DevSymbioide	bf149352d6	debug	7 months ago
DevSymbioide	70c30a3fb0	id_access_token optional	7 months ago
dlamarcheteamnet	bf344ee3fd	debug	7 months ago
dlamarcheteamnet	dc93bc0105	change error message 3pid invite	7 months ago
dlamarcheteamnet	8104b494a8	send Requester to get_user_role	7 months ago
dlamarcheteamnet	98a56cf408	send Requester to check_user_in_room from watcha_nextcloud	7 months ago
dlamarcheteamnet	ec2ccc606e	rm auth.py	7 months ago
dlamarcheteamnet	f7e651d772	remove last ','	7 months ago
dlamarcheteamnet	2d1bc912d8	modify registation	7 months ago
dlamarcheteamnet	7a6da4d87f	modify change_password	7 months ago
dlamarcheteamnet	1fb434fc05	deltas min54	7 months ago
dlamarcheteamnet	d8b97e0af5	assigne event_dict before reference	7 months ago
dlamarcheteamnet	1e924a5468	add comment #watcha	7 months ago
dlamarcheteamnet	ee020615bf	add is_partner in get_user_by_id	7 months ago
dlamarcheteamnet	a715b8c6ff	add is_partner in row and return in _query_for_auth	7 months ago
dlamarcheteamnet	7b6bbcac8a	add allow_locked in _wrapped_get_user_by_req	7 months ago
dlamarcheteamnet	ec63f5a8bd	remove thirdpid from watcha_registration	7 months ago
dlamarcheteamnet	35f7201193	Remove ThreepidBehaviour from watcha files	7 months ago
dlamarcheteamnet	4421b4f0e5	séparation auth	8 months ago
dlamarcheteamnet	eff5ada386	merge	8 months ago
Gerrit Gogel	1f88790764	Prevent locking up while processing batched_auth_events (#16968) ... This PR aims to fix #16895, caused by a regression in #7 and not fixed by #16903. The PR #16903 only fixes a starvation issue, where the CPU isn't released. There is a second issue, where the execution is blocked. This theory is supported by the flame graphs provided in #16895 and the fact that I see the CPU usage reducing and far below the limit. Since the changes in #7, the method `check_state_independent_auth_rules` is called with the additional parameter `batched_auth_events`: 6fa13b4f92/synapse/handlers/federation_event.py (L1741-L1743) It makes the execution enter this if clause, introduced with #15195 6fa13b4f92/synapse/event_auth.py (L178-L189) There are two issues in the above code snippet. First, there is the blocking issue. I'm not entirely sure if this is a deadlock, starvation, or something different. In the beginning, I thought the copy operation was responsible. It wasn't. Then I investigated the nested `store.get_events` inside the function `update`. This was also not causing the blocking issue. Only when I replaced the set difference operation (`-` ) with a list comprehension, the blocking was resolved. Creating and comparing sets with a very large amount of events seems to be problematic. This is how the flamegraph looks now while persisting outliers. As you can see, the execution no longer locks up in the above function.  Second, the copying here doesn't serve any purpose, because only a shallow copy is created. This means the same objects from the original dict are referenced. This fails the intention of protecting these objects from mutation. The review of the original PR https://github.com/matrix-org/synapse/pull/15195 had an extensive discussion about this matter. Various approaches to copying the auth_events were attempted: 1) Implementing a deepcopy caused issues due to builtins.EventInternalMetadata not being pickleable. 2) Creating a dict with new objects akin to a deepcopy. 3) Creating a dict with new objects containing only necessary attributes. Concluding, there is no easy way to create an actual copy of the objects. Opting for a deepcopy can significantly strain memory and CPU resources, making it an inefficient choice. I don't see why the copy is necessary in the first place. Therefore I'm proposing to remove it altogether. After these changes, I was able to successfully join these rooms, without the main worker locking up: - #synapse:matrix.org - #element-android:matrix.org - #element-web:matrix.org - #ecips:matrix.org - #ipfs-chatter:ipfs.io - #python:matrix.org - #matrix:matrix.org	9 months ago
Alexander Fechler	48f59d3806	deactivated flag refactored to filter deactivated users. (#16874) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	9 months ago
Patrick Cloke	696cc9e802	Stabilize support for Retry-After header (MSC4014) (#16947)	9 months ago
Quentin Gliech	4af33015af	Fix joining remote rooms when a `on_new_event` callback is registered (#16973) ... Since Synapse 1.76.0, any module which registers a `on_new_event` callback would brick the ability to join remote rooms. This is because this callback tried to get the full state of the room, which would end up in a deadlock. Related: https://github.com/matrix-org/synapse-auto-accept-invite/issues/18 The following module would brick the ability to join remote rooms: ```python from typing import Any, Dict, Literal, Union import logging from synapse.module_api import ModuleApi, EventBase logger = logging.getLogger(__name__) class MyModule: def __init__(self, config: None, api: ModuleApi): self._api = api self._config = config self._api.register_third_party_rules_callbacks( on_new_event=self.on_new_event, ) async def on_new_event(self, event: EventBase, _state_map: Any) -> None: logger.info(f"Received new event: {event}") @staticmethod def parse_config(_config: Dict[str, Any]) -> None: return None ``` This is technically a breaking change, as we are now passing partial state on the `on_new_event` callback. However, this callback was broken for federated rooms since 1.76.0, and local rooms have full state anyway, so it's unlikely that it would change anything.	9 months ago
Andrew Morgan	ab80b3412e	Revert "Ignore notification counts from rooms you've left" (#16981)	9 months ago
Andrew Morgan	8a05304222	Revert "Improve DB performance of calculating badge counts for push. (#16756)" (#16979)	9 months ago
Andrew Morgan	274f289a52	Ignore notification counts from rooms you've left (#16954) ... Co-authored-by: reivilibre <oliverw@matrix.org>	9 months ago
Erik Johnston	cdbbf3653d	Don't lock up when joining large rooms (#16903) ... Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>	9 months ago
kegsay	c51a2240d1	bugfix: always prefer unthreaded receipt when >1 exist (MSC4102) (#16927) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	9 months ago
Remi Rampin	0621e8eb0e	Add metric for emails sent (#16881) ... This adds a counter `synapse_emails_sent_total` for emails sent. They are broken down by `type`, which are `password_reset`, `registration`, `add_threepid`, `notification` (matching the methods of `Mailer`).	9 months ago
Erik Johnston	7b4d7429f8	Don't invalidate the entire event cache when we purge history (#16905) ... We do this by adding support to the LRU cache for "extra indices" based on the cached value. This allows us to efficiently map from room ID to the cached events and only invalidate those.	9 months ago
Erik Johnston	01910b981f	Add a config to not send out device list updates for specific users (#16909) ... List of users not to send out device list updates for when they register new devices. This is useful to handle bot accounts. This is undocumented as its mostly a hack to test on matrix.org. Note: This will still send out device list updates if the device is later updated, e.g. end to end keys are added.	9 months ago
Erik Johnston	bfa93d1d3b	Only do one concurrent fetch per server in keyring (#16894) ... Otherwise if we've stacked a bunch of requests for the keys of a server, we'll end up sending lots of concurrent requests for its keys, needlessly.	10 months ago
Erik Johnston	02a147039c	Increase batching when fetching auth chains (#16893) ... This basically reverts a change that was in https://github.com/element-hq/synapse/pull/16833, where we reduced the batching. The smaller batching can cause performance issues on busy servers and databases.	10 months ago
David Baker	71ca199165	Accept unprefixed form of MSC3981 recurse parameter (#16842) ... Now that the MSC3981 has passed FCP	10 months ago