20144 Commits (4d7e74b2e503373da66ec929afd1aa7010676878)

 

All Branches   

Search

Author	SHA1	Message	Date
Patrick Cloke	4d7e74b2e5	Support the MSC3715 for `/relations`. (#11941) ... This adds an unstable org.matrix.msc3715.dir parameter which acts like dir on /mesages.	3 years ago
Patrick Cloke	b65acead42	Fetch thread summaries for multiple events in a single query (#11752) ... This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	3 years ago
Richard van der Hoff	bb98c593a5	Prepare for rename of default complement branch (#11971) ... use `HEAD` rather than hardcoding `master`	3 years ago
Brendan Abolivier	0171fa5226	Remove deprecated user_may_create_room_with_invites callback (#11950) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	3 years ago
Erik Johnston	086d1d6d0b	Fix Newsfile ... \#11966 fixes a bug introduced by #11215, which isn't in a released version.	3 years ago
Erik Johnston	705a439972	Fix Newsfile ... \#11966 fixes a bug introduced by #11215, which isn't in a released version.	3 years ago
Erik Johnston	79fb64e417	Fix to-device being dropped in limited sync in SQLite. (#11966) ... If ther are more than 100 to-device messages pending for a device `/sync` will only return the first 100, however the next batch token was incorrectly calculated and so all other pending messages would be dropped. This is due to `txn.rowcount` only returning the number of rows that *changed*, rather than the number *selected* in SQLite.	3 years ago
Richard van der Hoff	4ef39f3353	fix import cycle (#11965)	3 years ago
Patrick Cloke	a121507cfe	Adds misc missing type hints (#11953)	3 years ago
Richard van der Hoff	c3db7a0b59	Tests: replace mocked Authenticator with the real thing (#11913) ... If we prepopulate the test homeserver with a key for a remote homeserver, we can make federation requests to it without having to stub out the authenticator. This has two advantages: * means that what we are testing is closer to reality (ie, we now have complete tests for the incoming-request-authorisation flow) * some tests require that other objects be signed by the remote server (eg, the event in `/send_join`), and doing that would require a whole separate set of mocking out. It's much simpler just to use real keys.	3 years ago
Dirk Klimpel	d36943c4df	Support the stable API endpoint for MSC3283: new settings in `/capabilities` endpoint (#11933)	3 years ago
Shay	1e12efa1b2	Drop support for EOL Ubuntu 21.04 (#11961)	3 years ago
Patrick Cloke	df36945ff0	Support pagination tokens from /sync and /messages in the relations API. (#11952)	3 years ago
Denis Kasak	337f38cac3	Implement a content type allow list for URL previews (#11936) ... This implements an allow list for content types for which Synapse will attempt URL preview. If a URL resolves to a resource with a content type which isn't in the list, the download will terminate immediately. This makes sense given that Synapse would never successfully generate a URL preview for such files in the first place, and helps prevent issues with streaming media servers, such as #8302. Signed-off-by: Denis Kasak dkasak@termina.org.uk	3 years ago
Alexander Mnich	06e5a76322	Fix broken link in README to admin API. (#11955) ... From when the documentation was converted from rst -> md.	3 years ago
Patrick Cloke	e4fdf459e2	Basic documentation for the release cycle. (#11954)	3 years ago
Brad Jones	3914576b2b	Fix example for structured logging. (#11946) ... The StreamHandler takes a stream parameter, not location.	3 years ago
Patrick Cloke	0408d694ee	Update changelog from #11867 to be a single line.	3 years ago
Patrick Cloke	d0e78af35e	Add missing type hints to synapse.replication. (#11938)	3 years ago
Patrick Cloke	8c94b3abe9	Experimental support to include bundled aggregations in search results (MSC3666) (#11837)	3 years ago
Patrick Cloke	6c0984e3f0	Remove unnecessary ignores due to Twisted upgrade. (#11939) ... Twisted 22.1.0 fixed some internal type hints, allowing Synapse to remove ignore calls for parameters to connectTCP.	3 years ago
Brendan Abolivier	6b91315ddf	Merge branch 'master' into develop	3 years ago
Brendan Abolivier	0b561a0ea1	Merge branch 'release-v1.52'	3 years ago
Patrick Cloke	63d90f10ec	Add missing type hints to synapse.replication.http. (#11856)	3 years ago
Patrick Cloke	8b309adb43	Fetch edits for multiple events in a single query. (#11660) ... This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	3 years ago
Patrick Cloke	380c3d40f4	Return JSON errors for unknown resources under /matrix/client. (#11930) ... Re-applies the changes from 3e0cfd447e (#11602), reverting d93ec0a0ba (#11764) now that the conflict with the webclient listener was fixed in 119edf51eb (#11895).	3 years ago
Brendan Abolivier	1aa2231e27	Fix wording	3 years ago
Brendan Abolivier	5cdd491310	Add words about the Twisted security fix	3 years ago
Brendan Abolivier	7d56b6c083	1.52.0	3 years ago
Andrew Morgan	3655585e85	Add a docstring to `add_device_change_to_streams` and fix some nearby types (#11912)	3 years ago
Brendan Abolivier	0640f8ebaa	Add a callback to allow modules to deny 3PID (#11854) ... Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.	3 years ago
Eric Eastwood	fef2e792be	Fix historical messages backfilling in random order on remote homeservers (MSC2716) (#11114) ... Fix https://github.com/matrix-org/synapse/issues/11091 Fix https://github.com/matrix-org/synapse/issues/10764 (side-stepping the issue because we no longer have to deal with `fake_prev_event_id`) 1. Made the `/backfill` response return messages in `(depth, stream_ordering)` order (previously only sorted by `depth`) - Technically, it shouldn't really matter how `/backfill` returns things but I'm just trying to make the `stream_ordering` a little more consistent from the origin to the remote homeservers in order to get the order of messages from `/messages` consistent ([sorted by `(topological_ordering, stream_ordering)`](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)). - Even now that we return backfilled messages in order, it still doesn't guarantee the same `stream_ordering` (and more importantly the [`/messages` order](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)) on the other server. For example, if a room has a bunch of history imported and someone visits a permalink to a historical message back in time, their homeserver will skip over the historical messages in between and insert the permalink as the next message in the `stream_order` and totally throw off the sort. - This will be even more the case when we add the [MSC3030 jump to date API endpoint](https://github.com/matrix-org/matrix-doc/pull/3030) so the static archives can navigate and jump to a certain date. - We're solving this in the future by switching to [online topological ordering](https://github.com/matrix-org/gomatrixserverlib/issues/187) and [chunking](https://github.com/matrix-org/synapse/issues/3785) which by its nature will apply retroactively to fix any inconsistencies introduced by people permalinking 2. As we're navigating `prev_events` to return in `/backfill`, we order by `depth` first (newest -> oldest) and now also tie-break based on the `stream_ordering` (newest -> oldest). This is technically important because MSC2716 inserts a bunch of historical messages at the same `depth` so it's best to be prescriptive about which ones we should process first. In reality, I think the code already looped over the historical messages as expected because the database is already in order. 3. Making the historical state chain and historical event chain float on their own by having no `prev_events` instead of a fake `prev_event` which caused backfill to get clogged with an unresolvable event. Fixes https://github.com/matrix-org/synapse/issues/11091 and https://github.com/matrix-org/synapse/issues/10764 4. We no longer find connected insertion events by finding a potential `prev_event` connection to the current event we're iterating over. We now solely rely on marker events which when processed, add the insertion event as an extremity and the federating homeserver can ask about it when time calls. - Related discussion, https://github.com/matrix-org/synapse/pull/11114#discussion_r741514793 Before | After --- | ---  |  #### Why aren't we sorting topologically when receiving backfill events? > The main reason we're going to opt to not sort topologically when receiving backfill events is because it's probably best to do whatever is easiest to make it just work. People will probably have opinions once they look at [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) which could change whatever implementation anyway. > > As mentioned, ideally we would do this but code necessary to make the fake edges but it gets confusing and gives an impression of “just whyyyy” (feels icky). This problem also dissolves with online topological ordering. > > -- https://github.com/matrix-org/synapse/pull/11114#discussion_r741517138 See https://github.com/matrix-org/synapse/pull/11114#discussion_r739610091 for the technical difficulties	3 years ago
Andrew Morgan	cf06783d54	Remove optional state of `ApplicationService.is_interested`'s `store` parameter (#11911)	3 years ago
Patrick Cloke	314ca4c86d	Pass the proper type when uploading files. (#11927) ... The Content-Length header should be treated as an int, not a string. This shouldn't have any user-facing change.	3 years ago
Andrew Morgan	e03dde259b	Clean up an indirect reference to the homeserver datastore (#11914)	3 years ago
Andrew Morgan	0c4878caf2	Add a unit test for users receiving their own device list updates (#11909)	3 years ago
Dirk Klimpel	65ef21b1c7	Clarify that users' media are also preview images (#11862)	3 years ago
kegsay	a3865ed525	Run Complement tests sequentially (#11910) ... Since #11811 there has been general Complement flakiness around networking. It seems like tests are hitting the wrong containers. In an effort to diagnose the cause of this, as well as reduce its impact on this project, set the parallelsim to 1 (no parallelism) when running tests. If this fixes the flakiness then this indicates the cause and I can diagnose this further. If this doesn't fix the flakiness then that implies some kind of test pollution which also helps to diagnose this further.	3 years ago
Jonathan de Jong	02632b3504	Stabilise MSC3231 (Token Based Registration) (#11867)	3 years ago
Richard van der Hoff	b3d155a749	Delete MSC1711_certificates_FAQ.md (#11907) ... This document isn't really relevant any more, and its existence is more confusing than helpful.	3 years ago
Richard van der Hoff	ce34ffacb1	Merge remote-tracking branch 'origin/master' into develop	3 years ago
Patrick Cloke	119edf51eb	Remove support for the webclient listener. (#11895) ... Also remove support for non-HTTP(S) web_client_location.	3 years ago
Christian Paul	6b1c265c21	Fix typo: unpind -> unbind (#11859) ... Co-authored-by: reivilibre <olivier@librepush.net>	3 years ago
Brendan Abolivier	d80d39b035	Add a ratelimiter for 3pid invite (#11892)	3 years ago
reivilibre	833247553f	Allow specifying the application service-specific `user_id` parameter in the `join` test helper. (#11616)	3 years ago
Richard van der Hoff	964f5b9324	Improve opentracing for federation requests (#11870) ... The idea here is to set the parent span for incoming federation requests to the *outgoing* span on the other end. That means that you can see (most of) the full end-to-end flow when you have a process that includes federation requests. However, in order not to lose information, we still want a link to the `incoming-federation-request` span from the servlet, so we have to create another span to do exactly that.	3 years ago
Richard van der Hoff	31b554c297	Fixes for opentracing scopes (#11869) ... `start_active_span` was inconsistent as to whether it would activate the span immediately, or wait for `scope.__enter__` to happen (it depended on whether the current logcontext already had an associated scope). The inconsistency was rather confusing if you were hoping to set up a couple of separate spans before activating either. Looking at the other implementations of opentracing `ScopeManager`s, the intention is that it *should* be activated immediately, as the name implies. Indeed, the idea is that you don't have to use the scope as a contextmanager at all - you can just call `.close` on the result. Hence, our cleanup has to happen in `.close` rather than `.__exit__`. So, the main change here is to ensure that `start_active_span` does activate the span, and that `scope.close()` does close the scope. We also add some tests, which requires a `tracer` param so that we don't have to rely on the global variable in unit tests.	3 years ago
Patrick Cloke	a8da046907	Invalidate the get_users_in_room{_with_profile} caches only when necessary. (#11878) ... The get_users_in_room and get_users_in_room_with_profiles are now only invalidated when the membership of a room changes, instead of during any state change in the room.	3 years ago
reivilibre	41818cda1f	Fix type errors introduced by new annotations in the Prometheus Client library. (#11832) ... Co-authored-by: David Robertson <davidr@element.io>	3 years ago
David Robertson	dd7f825118	Fix losing incoming EDUs if debug logging enabled (#11890) ... * Fix losing incoming EDUs if debug logging enabled Fixes #11889. Homeservers should only be affected if the `synapse.8631_debug` logger was enabled for DEBUG mode. I am not sure if this merits a bugfix release: I think the logging can be disabled in config if anyone is affected? But it is still pretty bad.	3 years ago