9147 Commits (f65e31d22fe9a0b07053ee15004e106ca787048b)

 

All Branches   

Search

Author	SHA1	Message	Date
Richard van der Hoff	f65e31d22f	Do an AAAA lookup on SRV record targets (#2462) ... Support SRV records which point at AAAA records, as well as A records. Fixes https://github.com/matrix-org/synapse/issues/2405	7 years ago
Matthew Hodgson	f496399ac4	fix thinko'd docstring	7 years ago
Erik Johnston	3166ed55b2	Fix device list when rejoining room (#2461)	7 years ago
Richard van der Hoff	c94ab5976a	Merge pull request #2459 from matrix-org/rav/keyring_cleanups ... Clean up Keyring code	7 years ago
Richard van der Hoff	6de74ea6d7	Fix logcontexts in _check_sigs_and_hashes	7 years ago
Richard van der Hoff	72472456d8	Add some more tests for Keyring	7 years ago
Richard van der Hoff	c5c24c239b	Fix logcontext handling in verify_json_objects_for_server ... preserve_context_over_fn is essentially broken, because (a) it pointlessly drops the current logcontext before calling its wrapped function, which means we don't get any useful logcontexts for _handle_key_deferred; (b) it wraps the resulting deferred in a _PreservingContextDeferred, which is very dangerous because you then can't yield on it without leaking context back into the reactor. Instead, let's specify that the resultant deferreds call their callbacks with no logcontext.	7 years ago
Richard van der Hoff	c5b0e9f485	Turn _start_key_lookups into an inlineCallbacks function ... ... which means that logcontexts can be correctly preserved for the stuff it does. get_server_verify_keys is now called with the logcontext, so needs to preserve_fn when it fires off its nested inlineCallbacks function. Also renames get_server_verify_keys to reflect the fact it's meant to be private.	7 years ago
Richard van der Hoff	abdefb8a01	Fix potential race in _start_key_lookups ... If the verify_request.deferred has already completed, then `remove_deferreds` will be called immediately. It therefore might resolve the server_to_deferred deferred while there are still other requests for that server in flight. To avoid that, we should build the complete list of requests, and *then* add the callbacks.	7 years ago
Richard van der Hoff	afbd773dc6	Add some comments to _start_key_lookups	7 years ago
Richard van der Hoff	2a4b9ea233	Consistency for how verify_request.deferred is called ... Define that it is run with no log context, and make sure that happens. If we aren't careful to reset the logcontext, we can't bung the deferreds into defer.gatherResults etc. We don't actually do that directly, but we *do* resolve other deferreds from affected callbacks (notably the server_to_deferred map in _start_key_lookups), and those *do* get passed into defer.gatherResults. It turns out that this way ends up being least confusing.	7 years ago
Richard van der Hoff	3b98439eca	Factor out _start_key_lookups ... ... to make it easier to see what's going on.	7 years ago
Richard van der Hoff	fde63b880d	Replace `server_and_json` with `verify_requests` ... This is a precursor to factoring some of this code out.	7 years ago
Richard van der Hoff	2d511defd9	pull out handle_key_deferred to top level ... There's no need for this to be a nested definition; pulling it out not only makes it more efficient, but makes it easier to check that it's not accessing any local variables it shouldn't be.	7 years ago
Richard van der Hoff	dd1ea9763a	Fix incorrect key_ids in error message	7 years ago
Richard van der Hoff	e76d1135dd	Invalidate signing key cache when we gat an update ... This might make the cache slightly more efficient.	7 years ago
Richard van der Hoff	fcf2c0fd1a	Remove redundant `preserve_fn` ... preserve_fn is a no-op unless the wrapped function returns a Deferred. verify_json_objects_for_server returns a list, so this is doing nothing.	7 years ago
Richard van der Hoff	9864efa532	Fix concurrent server_key requests (#2458) ... Fix a bug where we could end up firing off multiple requests for server_keys for the same server at the same time.	7 years ago
Richard van der Hoff	aa620d09a0	Add a config option to block all room invites (#2457) ... - allows sysadmins the ability to lock down their servers so that people can't send their users room invites.	7 years ago
Richard van der Hoff	2eabdf3f98	add some comments to on_exchange_third_party_invite_request	7 years ago
Richard van der Hoff	5ed109d59f	PoC for filtering spammy events (#2456) ... Demonstration of how you might add some hooks to filter out spammy events.	7 years ago
Richard van der Hoff	3f405b34e9	Fix overzealous kicking of guest users (#2453) ... We should only kick guest users if the guest access event is authorised.	7 years ago
Richard van der Hoff	290777b3d9	Clean up and document handling of logcontexts in Keyring (#2452) ... I'm still unclear on what the intended behaviour for `verify_json_objects_for_server` is, but at least I now understand the behaviour of most of the things it calls...	7 years ago
Erik Johnston	77c81ca6ea	Merge pull request #2451 from matrix-org/erikj/add_state_to_timeline ... Don't filter out current state events from timeline	7 years ago
Erik Johnston	2d1b7955ae	Don't filter out current state events from timeline	7 years ago
David Baker	862c8da560	Merge pull request #2450 from matrix-org/dbkr/push_event_id_only ... Add support for event_id_only push format	7 years ago
Erik Johnston	2d9f341c3e	Merge pull request #2449 from matrix-org/erikj/rejoin_device_lists ... Correctly handle leaving room in /key/changes	7 years ago
David Baker	436ee0a2ea	Also include the room_id ... as really it's part of the event ID	7 years ago
David Baker	b393f5db51	Use .get - it's much shorter	7 years ago
David Baker	a2562f9d74	Add support for event_id_only push format ... Param in the data dict of a pusher that tells an HTTP pusher to send just the event_id of the event it's notifying about and the notification counts. For clients that want to go & fetch the body of the event themselves anyway.	7 years ago
Erik Johnston	d6dadd95ac	Correctly handle leaving room in /key/changes	7 years ago
Erik Johnston	993d3f710b	Merge pull request #2443 from matrix-org/erikj/rejoin_device_lists ... Send down device list change notif when member leaves/rejoins room	7 years ago
Erik Johnston	4a94eb3ea4	Fix typo	7 years ago
Erik Johnston	3a0cee28d6	Actually hook leave notifs up	7 years ago
Erik Johnston	4f845a0713	Handle joining/leaving rooms in /keys/changes	7 years ago
Erik Johnston	473700f016	Get left rooms	7 years ago
Erik Johnston	9ce866ed4f	In sync handle device lists for newly joined/left rooms	7 years ago
Erik Johnston	69ef4987a6	Add left section to /keys/changes	7 years ago
Erik Johnston	53cc8ad35a	Send down device list change notif when member leaves/rejoins room	7 years ago
Richard van der Hoff	e2fcba038c	Merge pull request #2439 from matrix-org/rav/tox_tweaks ... do tox install with pip -e	7 years ago
Richard van der Hoff	5f59f20636	Merge remote-tracking branch 'origin/master' into develop	7 years ago
Richard van der Hoff	59de2c7afa	Exclude the github issue template from our sdist (#2440) ... PR #2413 added an issue template, but just adding files to the project directory upsets the packaging scripts: we need to explicitly include or exclude them. Move the template into a .github directory to make that easy, and to de-clutter the root a bit.	7 years ago
Richard van der Hoff	4b616c8cf2	Merge branch 'master' into develop	7 years ago
Richard van der Hoff	4dd61df6f8	do tox install with pip -e ... - this ensures we end up with a working virtualenv which we can use for other things.	7 years ago
Erik Johnston	c0c31656ff	Merge pull request #2433 from ptman/patch-1 ... Document known to work postgres version	7 years ago
Paul Tötterman	8b16b43b7f	Document known to work postgres version	7 years ago
Richard van der Hoff	dff396de0f	Set --python when running sytest ... .. because I want to make the 'install_and_run' script useful for non-synapse jobs, which do not accept --python. In any case we set up the path here, so sytest shouldn't be guessing it.	7 years ago
Richard van der Hoff	f06ffdb6fa	fix python path in jenkins scripts	7 years ago
Richard van der Hoff	6e67aaa7f2	Set --python when running sytest ... .. because I want to make the 'install_and_run' script useful for non-synapse jobs, which do not accept --python. In any case we set up the path here, so sytest shouldn't be guessing it.	7 years ago
Richard van der Hoff	934ab76835	Merge pull request #2428 from matrix-org/rav/update_upgrade ... Tweaks to the upgrade instructions	7 years ago