Refactor SAML/CAS api to use value translation (#2318)

v2.11
Maxime Besson 4 years ago
parent acef2ed5c6
commit 13b1097304
  1. 13
      lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Api/Providers/CasApp.pm
  2. 13
      lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Api/Providers/SamlSp.pm

@ -266,8 +266,10 @@ sub _getCasAppByConfKey {
for for
my $configOption ( keys %{ $conf->{casAppMetaDataOptions}->{$confKey} } ) my $configOption ( keys %{ $conf->{casAppMetaDataOptions}->{$confKey} } )
{ {
$options->{ $self->_translateOptionConfToApi($configOption) } = my $optionName = $self->_translateOptionConfToApi($configOption);
$conf->{casAppMetaDataOptions}->{$confKey}->{$configOption}; my $optionValue = $self->_translateValueConfToApi( $configOption,
$conf->{casAppMetaDataOptions}->{$confKey}->{$configOption} );
$options->{$optionName} = $optionValue;
} }
return { return {
@ -326,8 +328,11 @@ sub _pushCasApp {
if ( defined $push->{options} ) { if ( defined $push->{options} ) {
foreach ( keys %{ $push->{options} } ) { foreach ( keys %{ $push->{options} } ) {
$translatedOptions->{ $self->_translateOptionApiToConf( $_, my $optionName = $self->_translateOptionApiToConf( $_, 'casApp' );
'casApp' ) } = $push->{options}->{$_}; my $optionValue =
$self->_translateValueApiToConf( $_, $push->{options}->{$_} );
$translatedOptions->{$optionName} = $optionValue;
} }
my $res = $self->_hasAllowedAttributes( $translatedOptions, my $res = $self->_hasAllowedAttributes( $translatedOptions,

@ -255,8 +255,11 @@ sub _getSamlSpByConfKey {
my $options = {}; my $options = {};
for my $confOption ( keys %{ $conf->{samlSPMetaDataOptions}->{$confKey} } ) for my $confOption ( keys %{ $conf->{samlSPMetaDataOptions}->{$confKey} } )
{ {
$options->{ $self->_translateOptionConfToApi($confOption) } = my $optionName = $self->_translateOptionConfToApi($confOption);
$conf->{samlSPMetaDataOptions}->{$confKey}->{$confOption}; my $optionValue = $self->_translateValueConfToApi( $confOption,
$conf->{samlSPMetaDataOptions}->{$confKey}->{$confOption} );
$options->{$optionName} = $optionValue;
} }
# Get macros # Get macros
@ -378,8 +381,10 @@ sub _pushSamlSp {
if ( defined $push->{options} ) { if ( defined $push->{options} ) {
foreach ( keys %{ $push->{options} } ) { foreach ( keys %{ $push->{options} } ) {
$translatedOptions->{ $self->_translateOptionApiToConf( $_, my $optionName = $self->_translateOptionApiToConf( $_, 'samlSP' );
'samlSP' ) } = $push->{options}->{$_}; my $optionValue =
$self->_translateValueApiToConf( $_, $push->{options}->{$_} );
$translatedOptions->{$optionName} = $optionValue;
} }
my $res = $self->_hasAllowedAttributes( $translatedOptions, my $res = $self->_hasAllowedAttributes( $translatedOptions,

Loading…
Cancel
Save