Replace 400 codes by 200 due to an angular bug (#952)

environments/ppa-mbqj77/deployments/1
Xavier Guimard 9 years ago
parent 6eed020081
commit b80dd05a9a
  1. 14
      lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Notifications.pm

@ -248,21 +248,21 @@ sub notification {
sub newNotification { sub newNotification {
my ( $self, $req, @other ) = @_; my ( $self, $req, @other ) = @_;
return $self->sendError( $req, return $self->sendError( $req,
'There is no subkey for "newNotification"', 400 ) 'There is no subkey for "newNotification"', 200 )
if (@other); if (@other);
my $json = $req->jsonBodyToObj; my $json = $req->jsonBodyToObj;
unless ( defined($json) ) { unless ( defined($json) ) {
return $self->sendError( $req, undef, 400 ); return $self->sendError( $req, undef, 200 );
} }
foreach my $r (qw(uid date reference xml)) { foreach my $r (qw(uid date reference xml)) {
return $self->sendError( $req, "Missing $r", 400 ) return $self->sendError( $req, "Missing $r", 200 )
unless ( $json->{$r} ); unless ( $json->{$r} );
} }
unless ( $json->{date} =~ /^\d{4}-\d{2}-\d{2}$/ ) { unless ( $json->{date} =~ /^\d{4}-\d{2}-\d{2}$/ ) {
return $self->sendError( $req, "Malformed date", 400 ); return $self->sendError( $req, "Malformed date", 200 );
} }
utf8::decode( $json->{xml} ); utf8::decode( $json->{xml} );
@ -282,7 +282,7 @@ sub newNotification {
"Notification not created: $@$Lemonldap::NG::Common::Notification::msg", "Notification not created: $@$Lemonldap::NG::Common::Notification::msg",
'error' 'error'
); );
return $self->sendError( $req, "Notification not created", 400 ); return $self->sendError( $req, "Notification not created: $@$Lemonldap::NG::Common::Notification::msg", 200 );
} }
else { else {
return $self->sendJSONresponse( $req, { result => 1 } ); return $self->sendJSONresponse( $req, { result => 1 } );
@ -294,13 +294,13 @@ sub updateNotification {
my $json = $req->jsonBodyToObj; my $json = $req->jsonBodyToObj;
unless ( defined($json) ) { unless ( defined($json) ) {
return $self->sendError( $req, undef, 400 ); return $self->sendError( $req, undef, 200 );
} }
# For now, only "mark as done" is proposed # For now, only "mark as done" is proposed
unless ( $json->{done} ) { unless ( $json->{done} ) {
return $self->sendError( $req, 'Only "done=1" is accepted for now', return $self->sendError( $req, 'Only "done=1" is accepted for now',
400 ); 200 );
} }
my $id = $req->params('notificationId') or die; my $id = $req->params('notificationId') or die;
my ( $uid, $ref ) = ( $id =~ /([^_]+?)_(.+)/ ); my ( $uid, $ref ) = ( $id =~ /([^_]+?)_(.+)/ );

Loading…
Cancel
Save