apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Michel Hollands	10e3d80731	Fix distributor latency panel (#8760 ) What this PR does / why we need it: https://github.com/grafana/loki/pull/8247 changes a metric generated by a recording rule. This fixes the "Distributor Panel" to use this different metric. Tested by changing the "Distributor Panel" manually to see it showed results. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Danny Kopping	0bf0b6b718	Modify debug loki build to work on any architecture, including ARM (#8758 ) What this PR does / why we need it: On my M1 Pro, `make loki-debug-image` produces the following output: ```bash qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory ``` This is because we run `delve` as the entrypoint for the debug image, and `delve` is being copied from `loki-build-image` which is exclusively built as `amd64` (we should make this a multi-arch image... created https://github.com/grafana/loki/issues/8759). This change will work with whichever host OS is building the image and download `delve` using that architecture instead of relying on the `loki-build-image` version.	2 years ago
Michel Hollands	15fda6bf39	Change severity of PromtailFileMissing alert to warning (#8757 ) The PromtailFileMissing alert is not critical. This changes it to a warning. Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Michel Hollands	1c4dd6ad40	Use changed metric in operational dashboard (#8749 ) What this PR does / why we need it: The metric `job_route` was changed to `cluster_job_route` in https://github.com/grafana/loki/pull/8247. This PR updates this metric in the operational dashboard. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Travis Patterson	9ac33e216e	Reimplement Unpack in terms of jsonparser rather than jsoniter (#8739 ) This PR reimplements the functionality of `Unpack` using the `jsonparser` library rather than `jsoniter` Benchmarks: ``` name old time/op new time/op delta _Parser/unpack/no_labels_hints-8 900ns ± 4% 309ns ± 3% -65.62% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 1.06µs ±12% 0.32µs ± 2% -69.72% (p=0.000 n=9+10) _Parser/unpack-not_json_line/no_labels_hints-8 37.5ns ± 8% 10.6ns ± 3% -71.70% (p=0.000 n=9+9) _Parser/unpack-not_json_line/labels_hints-8 39.6ns ±11% 10.3ns ± 2% -74.00% (p=0.000 n=10+9) name old alloc/op new alloc/op delta _Parser/unpack/no_labels_hints-8 536B ± 0% 80B ± 0% -85.07% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 536B ± 0% 80B ± 0% -85.07% (p=0.000 n=10+10) _Parser/unpack-not_json_line/no_labels_hints-8 0.00B 0.00B ~ (all equal) _Parser/unpack-not_json_line/labels_hints-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta _Parser/unpack/no_labels_hints-8 17.0 ± 0% 4.0 ± 0% -76.47% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 17.0 ± 0% 4.0 ± 0% -76.47% (p=0.000 n=10+10) _Parser/unpack-not_json_line/no_labels_hints-8 0.00 0.00 ~ (all equal) _Parser/unpack-not_json_line/labels_hints-8 0.00 0.00 ~ (all equal) ```	2 years ago
Travis Patterson	9c6e509a6a	Reimplement JsonExpressionParser in terms of jsonparser (#8734 ) This PR reimplements the functionality of `JSONExpressionParser` using the `jsonparser` library rather than `jsoniter` Benchmarks: ``` benchstat json_expression_old.txt json_expression_new.txt name old time/op new time/op delta JsonExpressionParser/json-expression-8 4.15µs ± 4% 0.82µs ± 3% -80.17% (p=0.000 n=10+10) name old alloc/op new alloc/op delta JsonExpressionParser/json-expression-8 1.07kB ± 0% 0.02kB ± 0% -97.76% (p=0.000 n=10+10) name old allocs/op new allocs/op delta JsonExpressionParser/json-expression-8 72.0 ± 0% 2.0 ± 0% -97.22% (p=0.000 n=10+10) ```	2 years ago
Christian Haudum	4b74a5b815	Implement hierarchical queues for query scheduler (#8691 ) ### What this PR does / why we need it: This PR is the first step towards hierarchical queues within the query scheduler. Hierarchical queues can be used to ensure query fairness across multiple actors within a single tenant, such as individual (human) users using the same tenant. The change is described in the LID ["Query fairness across users within tenants"](https://grafana.com/docs/loki/next/lids/0003-queryfairnessinscheduler/). * Extract metrics for `RequestQueue` into their own `metrics` field, so that they can extended and passed more easily in the future. * Move mapping for tenant queues into its own data structure (ordered map) so its functionality can be reused. It also simplifies the code inside the `tenantQueues` struct. * Add the `LeafQueue` struct that implements hierarchical queues. Sub-queues are dequeued in a round-robin manner using the same implementation of `Mapping` that is also used by the tenant queues. ### Special notes for your reviewer Part of https://github.com/grafana/loki/pull/8585 Contains the changes from PR https://github.com/grafana/loki/pull/8722 This PR does not yet make use of the new hierarchical queues, it only adds the relevant data structures. Wiring up will be done in a follow up PR. While the new `Mapping` data structure adds an unsignificant overhead to the time/op I consider the simplification an overall better tradeoff. ```console $ benchstat scheduler-bench-old.txt scheduler-bench-new.txt name old time/op new time/op delta GetNextRequest-8 18.0µs ± 2% 20.5µs ± 3% +13.89% (p=0.008 n=5+5) QueueRequest-8 56.6µs ± 0% 53.5µs ± 3% -5.48% (p=0.008 n=5+5) name old alloc/op new alloc/op delta GetNextRequest-8 1.60kB ± 0% 1.60kB ± 0% ~ (all equal) QueueRequest-8 35.6kB ± 0% 29.8kB ± 0% -16.37% (p=0.008 n=5+5) name old allocs/op new allocs/op delta GetNextRequest-8 100 ± 0% 100 ± 0% ~ (all equal) QueueRequest-8 819 ± 0% 806 ± 0% -1.59% (p=0.008 n=5+5) ``` #### Complexity of operations \| Operation \| Function \| Complexity \| \| --------- \| -------- \| ---------- \| \| Insert \| `Put(key string, value tenantQueue) bool` \| `O(1)`\| \| Select \| `GetNext(idx QueueIndex) tenantQueue` \| `O(1)` (best case) `O(n)` (worst case) \| \| Remove \| `Remove(key string) bool` \| `O(1)` \| --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Sandeep Sukhani	162a2d0057	deletion: fix issue in processing delete requests with tsdb index (#8665 ) What this PR does / why we need it: When a delete request creates a new chunk from an existing chunk, we index it to the index store. In TSDB, we [drop](`944b488bd2/pkg/storage/stores/tsdb/head_manager.go (L235-L237)`) `__name__` label, which was being added to chunkrefs for historical reasons. However, this was not done while indexing chunks from the deletion code, causing deletion to fail with the error [chunk insertion is only allowed on existing streams](`619c2212f5/pkg/storage/stores/tsdb/builder.go (L67)`). This PR handles the issue by dropping the `__name__` label and adding relevant tests. Special notes for your reviewer: I will add an integration test for deletion with TSDB once we have PR https://github.com/grafana/loki/pull/7754 merged since it does some groundwork to run integration tests with both `boltdb-shipper` and `tsdb`. Checklist - [x] Tests updated - [x] `CHANGELOG.md` updated	2 years ago
dependabot[bot]	466a32192a	operator: Bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 (#8726 ) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Dylan Guedes	ea6abbfd07	Loki-Mixin: Remove query-readiness panel (#8735 ) What this PR does / why we need it: Remove from loki-mixin the panel that shows the query_readiness metric. The metric was removed a while ago.	2 years ago
J Stickler	673bfd603b	Fixing broken link (404) (#8688 ) This was reported to the docs team via Slack. Fixing broken link from Promtail Scraping file to Promtail Configuration file.	2 years ago
Danny Kopping	6c0f3442cc	Tools: add tool to determine which release (if any) a commit appears in (#8706 ) I've often found myself needing to determine which release a particular PR appears in. This tool makes that easy, and it accepts the merge commit ref of the PR. Example from https://github.com/grafana/loki/pull/7044, in which [a user is asking which version this feature appears in](https://github.com/grafana/loki/pull/7044#issuecomment-1455694087). ```bash $ ./tools/which-release.sh `93a5a71` Commit was found in the following releases: release-2.7.x ```	2 years ago
Dylan Guedes	656ad800fe	Promtail: Stop ticker to avoid leaking (#8695 ) What this PR does / why we need it: Call `Stop` to positions ticker to release associated resources/avoid leaking.	2 years ago
Mohamed-Amine Bouqsimi	519e25c714	operator: Fix gateway's nodeSelector and tolerations (#8707 )	2 years ago
Libby Anderson	06db3b96bb	Update retention_support.md (#8342 ) Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Karsten Jeschkies	28d845d26c	Make Loki Overrides public. (#8696 ) What this PR does / why we need it: Follow up to #8689 that will allow to inject a different overrides implementation. Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	2 years ago
Travis Patterson	7f42137584	Use Line Filters in StringLabelFilter (#8659 ) We've done a ton of work to optimize regexes in line filters but nothing in label filters. To avoid duplicating the work or reworking all of our filter types, this PR creates a new label filter that has an optimized line filter. It uses that against the label value to determine if they match. Note on Benchmarks: the input string for this is 1114195 bytes long. The `not` test tells us that our approach is quite a lot slower when the literal pattern isn't present in the input. The size of the input really emphasizes it. Benchmarks: ``` name old time/op new time/op delta LineLabelFilters/foo-8 50.6ns ± 9% 14.3ns ± 1% -71.67% (p=0.000 n=10+8) LineLabelFilters/not-8 15.7ns ± 1% 64165.6ns ± 2% +407766.77% (p=0.000 n=10+10) LineLabelFilters/(foo)-8 58.4ns ± 1% 14.8ns ±10% -74.68% (p=0.000 n=9+9) LineLabelFilters/(foo\|ba)-8 64.9ns ± 0% 18.2ns ± 2% -71.90% (p=0.000 n=7+9) LineLabelFilters/(foo\|ba\|ar)-8 74.8ns ± 7% 21.4ns ± 2% -71.42% (p=0.000 n=10+8) LineLabelFilters/(foo\|(ba\|ar))-8 65.1ns ± 1% 18.1ns ± 2% -72.22% (p=0.000 n=8+8) LineLabelFilters/foo.-8 882ns ± 4% 15ns ±11% -98.30% (p=0.000 n=9+10) LineLabelFilters/.foo-8 11.5ns ± 8% 14.9ns ± 7% +30.39% (p=0.000 n=10+10) LineLabelFilters/.foo.-8 5.46µs ± 7% 0.01µs ± 3% -99.74% (p=0.000 n=10+9) LineLabelFilters/(.)(foo).-8 6.26µs ± 7% 0.01µs ± 2% -99.77% (p=0.000 n=10+9) LineLabelFilters/(foo.\|.ba)-8 5.58µs ± 3% 0.02µs ± 8% -99.67% (p=0.000 n=9+10) LineLabelFilters/(foo.\|.bar.)-8 7.02µs ± 7% 0.02µs ± 8% -99.73% (p=0.000 n=10+10) LineLabelFilters/.foo.\|bar-8 5.53µs ± 6% 0.02µs ± 2% -99.67% (p=0.000 n=10+8) LineLabelFilters/.foo\|bar-8 3.73µs ± 6% 0.02µs ± 3% -99.52% (p=0.000 n=10+9) LineLabelFilters/(?:.foo.\|bar)-8 5.43µs ± 8% 0.02µs ± 8% -99.65% (p=0.000 n=10+10) LineLabelFilters/(?P<foo>.foo.\|bar)-8 5.71µs ± 3% 0.02µs ±10% -99.68% (p=0.000 n=9+9) LineLabelFilters/.foo.\|bar\|buzz-8 5.34µs ± 2% 0.02µs ± 3% -99.65% (p=0.000 n=10+9) LineLabelFilters/.foo.\|bar\|uzz-8 5.36µs ± 1% 0.02µs ± 3% -99.60% (p=0.000 n=8+8) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 68.8ns ± 8% 22.6ns ± 7% -67.19% (p=0.000 n=10+10) LineLabelFilters/f\|foo\|foobar-8 77.1ns ± 1% 18.6ns ± 9% -75.90% (p=0.000 n=8+10) LineLabelFilters/f.\|foobar.\|.buzz-8 5.64µs ± 7% 0.02µs ±10% -99.60% (p=0.000 n=10+10) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 6.29µs ± 8% 0.02µs ±10% -99.65% (p=0.000 n=10+10) LineLabelFilters/.-8 963ns ± 8% 2ns ±14% -99.77% (p=0.000 n=10+10) LineLabelFilters/.\|.-8 4.46µs ± 8% 0.00µs ± 8% -99.95% (p=0.000 n=10+10) LineLabelFilters/.\|\|\|\|-8 2.99µs ± 1% 0.00µs ±16% -99.93% (p=0.000 n=8+10) LineLabelFilters/#00-8 43.5ns ± 8% 2.1ns ± 1% -95.25% (p=0.000 n=10+8) LineLabelFilters/(?i)foo-8 71.7ns ± 6% 13.1ns ± 1% -81.73% (p=0.000 n=10+8) LineLabelFilters/(?i)界-8 16.5ns ± 8% 150.2ns ± 8% +809.55% (p=0.000 n=10+10) LineLabelFilters/(?i)ïB-8 23.8ns ± 1% 14748979.8ns ± 7% +62074730.81% (p=0.000 n=8+10) LineLabelFilters/(?:)foo\|fatal\|exception-8 185ns ± 2% 21ns ± 2% -88.38% (p=0.000 n=9+8) LineLabelFilters/(?i)foo\|fatal\|exception-8 78.4ns ± 3% 20.2ns ± 2% -74.23% (p=0.000 n=9+9) LineLabelFilters/(?i)f\|foo\|foobar-8 94.3ns ±16% 15.4ns ± 9% -83.66% (p=0.000 n=10+10) LineLabelFilters/(?i)f\|fatal\|e.-8 65.7ns ± 5% 18.2ns ± 3% -72.24% (p=0.000 n=9+8) LineLabelFilters/(?i).foo.-8 6.04µs ± 8% 0.01µs ± 2% -99.78% (p=0.000 n=10+10) name old alloc/op new alloc/op delta LineLabelFilters/foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/not-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00B 0.00B ~ (all equal) LineLabelFilters/#00-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)界-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i).foo.-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta LineLabelFilters/foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/not-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00 0.00 ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00 0.00 ~ (all equal) LineLabelFilters/#00-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)界-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i).foo.*-8 0.00 0.00 ~ (all equal) ```	2 years ago
Dylan Guedes	f9a1f2d94e	Loki: Stop running tickers on deletes (#8697 ) What this PR does / why we need it: Calls `ticker.Stop()` to avoid leaking ticker resources for `GenNumberLoader` and `deleteRequestsClient`.	2 years ago
Callum Styan	9a2a038f43	Allow passing of context to query related limits functions (#8689 ) In this PR we're allowing for passing of a `context.Context` via the Limits interfaces (some of which are new, to clean up hardcoding/embedding of `validation.Overrides`) This is based on work/ideas by @jeschkies . Fixes #8694 --------- Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Kaviraj Kanagaraj	371455770f	doc(best-practices): Update default value of `max_chunk_age`. (#8685 )	2 years ago
e0031374	2dcaba3176	Loki Getting Started: Fix example query that was not working (#8668 ) What this PR does / why we need it: Previously example query was `evaluate-loki_flog_1` this was not the label used in flog. This results in query not returning any logs which beginners may be unsure of the cause of the issue. This might also be an issue if flog was running in the background and logs are not displayed. Changed to `evaluate-loki-flog-1`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Trivial fix to "Getting Started" documentation Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	ab7a970b94	Querier/Ruler: add histogram to track fetched chunk size distribution (#8682 ) What this PR does / why we need it: We are looking at making some changes to the chunk caching strategy, and we need this data to know what size chunks we're typically requesting. For example, if the overwhelming majority of chunks are small we may decide to cache only small chunks to decrease the number of requests to the object store; we could fit more chunks in cache this way, which may have a positive performance impact.	2 years ago
Bryan Boreham	08ac5336d5	WAL: store pointers in record pool (#8667 ) What this PR does / why we need it: Storing a slice in `sync.Pool` wastes 24 bytes every time it is returned to the heap; see https://staticcheck.io/docs/checks#SA6002 Storing a pointer to a slice allows the Pool to work without waste. This came up in discussion about the benchmark in #8489 - with this change the memory usage comes down: ``` name old time/op new time/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 7.37ms ±13% 7.45ms ± 9% ~ (p=0.841 n=5+5) name old alloc/op new alloc/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 727kB ± 0% 679kB ± 0% -6.63% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 12.0k ± 0% 10.0k ± 0% -16.68% (p=0.000 n=5+4) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - NA `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Travis Patterson	c42a0ba868	Optimize .+ regex line filter (#8646 ) Interpolated variables from Grafana dashboards may result in the regex matcher `.+`. Filters with `+` are already being rewritten to be non greedy but there is a further optimization to make replace the regex altogether with a filter that just matchers `len(line) > 0`	2 years ago
Robert Jacob	0c071d8a79	operator: Fix version inconsistency in generated OpenShift bundle (#8666 )	2 years ago
Christian Haudum	a5652c8027	Clean up scheduler code to prepare upcoming changes (#8643 ) In preparation of https://github.com/grafana/loki/pull/8585 this PR contains some cleanups. Changes in this PR do not change the implementation, but only rename functions and data structures to make them more generic and/or suitable for extending. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Pablo	a15365202d	Optimize Promtail wal writer to batch both series and entries record (#8489 )	2 years ago
Grot (@grafanabot)	215f37cfa3	[CI/CD] Update yaml file `./production/helm/loki/values.yaml` (+1 other) (#8655 ) Here is a summary of the updates contained in this PR: * Update attribute `$.enterprise.version` in yaml file `./production/helm/loki/values.yaml` to the following value: `v1.6.2` * Bump version of Helm Chart Add changelog entry to `./production/helm/loki/CHANGELOG.md` Re-generate docs Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Christian Haudum	cec264996b	LID: Improve scheduler to control QoS across users within a tenant (#8585 ) Even though Loki is built as multi-tenant system by default, there are use-cases where a Loki installation only has a very large, single tenant, e.g. dedicated Loki cells for customers in Grafana Cloud. However, there are potentially a lot of different users using the same tenant to query logs, such as users accessing Loki from Grafana or via CLI or HTTP API. This can lead to contention between queries of different users, because they all share the same tenant. While the current implementation of the scheduler queues allows for QoS guarantees between tenants, it does not account for QoS guarantees across individual users within a single tenant. --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	2 years ago
Jan Jansen	84c5e20af1	S3: add support for s3 session token (#8474 ) We want to automate the access account rotation. This is that easy at moment with service accounts in MinIO. Our currently life time of tokens is 3 months with MinIO STS works this fine. Signed-off-by: Jan Jansen <jan.jansen@gdata.de>	2 years ago
Danny Kopping	6bf782b0a7	Ruler: do not keep appending logger keys (#8650 ) What this PR does / why we need it: Corrects a logger which was accidentally appending keys in every loop iteration, causing massive lines to be ingested	2 years ago
Dylan Guedes	c06f1daf59	Update CHANGELOG.md (#8633 ) What this PR does / why we need it: Update our changelog to inherit v2.7.4 release notes	2 years ago
Angus Dippenaar	5c5b27db50	[logcli] set default instead of error for parallel-max-workers validation (#8641 ) What this PR does / why we need it: Fixes regression reported here: https://github.com/grafana/loki/pull/8518#issuecomment-1446014229 @dannykopping can you please verify that it fixes the issue for you? Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Vladyslav Diachenko	88120a0857	added missed binaries required to run `./tools/image-tag` script (#8640 ) What this PR does / why we need it: [This drone step](https://drone.grafana.net/grafana/loki/20764/21/3) had to prepare a config for the `updater` to update loki helm chart with the latest image version automatically. However, it failed due to an error: ``` + RELEASE_TAG=$(./tools/image-tag) env: can't execute 'bash': No such file or directory ``` I forgot to install `bash` and `git` before running this script inside `alpine` container.	2 years ago
J Stickler	5fbc747392	Fixing broken link and removing out of date blog post. (#8632 ) Which issue(s) this PR fixes: * Starts to address #8631 * Removes link to outdated blog post that says "Loki is very much alpha software and should not be used in production environments." * Fixes broken link to Configuration file.	2 years ago
Trevor Whitney	dac3b84d08	Loki cloud integration instructions (and necessary mixin changes) (#8492 ) What this PR does / why we need it: This PR is a first stab at documentation for setting up the Grafana Cloud Loki Integration to monitor a local Loki cluster, installed using the helm chart, using Grafana Cloud. In addition to instructions on how to collect the necessary kubernetes metrics, there were also some things with the Loki mixin (which provides dashboards, alerts, and rules to the integration) that needed to be fixed. For example, our dashboards rely on there being a cluster label on our recording rules, yet our mixin does not include this? Also, we are still including `cortex-gw` panels even when the mixin is compile with `internal_components: false`. Special notes for your reviewer: The changes to the mixin will not be reflected in the current version of the integration. We need to merge this PR first then update the integration. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Susana Ferreira	9f8aa4b98a	Helm: fix enterprise-logs license secret name (#8498 ) What this PR does / why we need it: Rename `gel-license.jwt` property of secret `gel-secrets` to `license.jwt` on enterprise-logs chart to make it consistent betwen `gel-secrets` and `gel-license` kubectl secrets. * Fix the `stringData` property of the GEL secret, to contain `license.jwt` property when importing: * `gel-secrets`: containing both the `gcp_service_account.json` and `license.jwt` properties `6ece17a82f/production/helm/loki/docs/examples/enterprise/enterprise-secrets.yaml (L1-L12)` * `gel-license`: containing only the `license.jwt` property `6a7403c4f5/tools/dev/k3d/environments/helm-cluster/main.jsonnet (L213-L217)` * Minor fixes in the README documentation. Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Vladyslav Diachenko	78db3f8d11	Helm chart auto update (#8331 ) What this PR does / why we need it: implemented a pipeline that will run on Loki tag that starts with `v` and will prepare updater config and run updater with prepared config to update Loki helm chart with the released Loki version. Example of PR that is generated by this Pipeline : [here](https://github.com/grafana/loki/pull/8328)	2 years ago
Susana Ferreira	141ee25c0e	Helm: update changelog CI comment (#8603 ) What this PR does / why we need it: Update the helm changelog CI comment to clarify that the pipeline is only used for new Loki releases. Related to PR: https://github.com/grafana/loki/pull/8323 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Susana Ferreira	2a3874b240	Helm: update changelog with changes from PR #8467 (#8601 ) What this PR does / why we need it: Update changelog with changes from PR #8467 and bump helm chart version to 4.6.2 Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	31f8bf9a73	Bump golang.org/x/net from 0.4.0 to 0.7.0 in /pkg/push (#8562 ) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="`8e2b117aee`"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li> <li><a href="`547e7edf38`"><code>547e7ed</code></a> http2: avoid referencing ResponseWrite.Write parameter after returning</li> <li><a href="`39940adcaa`"><code>39940ad</code></a> html: parse comments per HTML spec</li> <li><a href="`87ce33ecb4`"><code>87ce33e</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`415cb6d518`"><code>415cb6d</code></a> all: fix some comments</li> <li><a href="`7e3c19ca52`"><code>7e3c19c</code></a> all: correct typos in comments</li> <li><a href="`296f09aa38`"><code>296f09a</code></a> http2: case insensitive handling for 100-continue</li> <li><a href="`f8411da775`"><code>f8411da</code></a> nettest: fix tests on dragonfly and js/wasm</li> <li><a href="`8e0e7d8d38`"><code>8e0e7d8</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`7805fdc37d`"><code>7805fdc</code></a> http2: rewrite inbound flow control tracking</li> <li>Additional commits viewable in <a href="https://github.com/golang/net/compare/v0.4.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.4.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
dependabot[bot]	0b1bffaa9e	Bump golang.org/x/net from 0.5.0 to 0.7.0 (#8563 ) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="`8e2b117aee`"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li> <li><a href="`547e7edf38`"><code>547e7ed</code></a> http2: avoid referencing ResponseWrite.Write parameter after returning</li> <li><a href="`39940adcaa`"><code>39940ad</code></a> html: parse comments per HTML spec</li> <li><a href="`87ce33ecb4`"><code>87ce33e</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="`415cb6d518`"><code>415cb6d</code></a> all: fix some comments</li> <li><a href="`7e3c19ca52`"><code>7e3c19c</code></a> all: correct typos in comments</li> <li><a href="`296f09aa38`"><code>296f09a</code></a> http2: case insensitive handling for 100-continue</li> <li><a href="`f8411da775`"><code>f8411da</code></a> nettest: fix tests on dragonfly and js/wasm</li> <li>See full diff in <a href="https://github.com/golang/net/compare/v0.5.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.5.0&new-version=0.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/grafana/loki/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago
Zach Watson	d59792ffa3	production: Add missing string formatter token to nginx.conf config map (#8580 ) The `nginx.conf` config map server settings has a `proxy_set_header` line setting the X-Scope-OrgID using the gateway tenant ID. The Jsonnet string formatter is missing the `s` token. This PR adds the missing formatter token to the `nginx.conf` config map that's causing an `Unrecognized conversion type: ;` when trying to deploy. Fixes a bug introduced in #7624	2 years ago
Bryan Boreham	6fd4b5e89b	Update prometheus/prometheus from 2.41 to 2.42 (#8571 ) What this PR does / why we need it: Brings in the latest updates from upstream. These open up some opportunities for optimisations in TSDB indexing. Dependencies updated: * github.com/Azure/go-autorest/autorest/adal v0.9.21 -> v0.9.22 (comment-only change) * github.com/docker/docker v20.10.21 -> v20.10.23 (fixing filters bug) * golang.org/x/exp fae10dda9338 -> d38c7dcee874 (optimisations in `BinarySearch` function) Indirect dependencies also updated: * github.com/digitalocean/godo v1.91.1 -> v1.95.0 (nothing alarming in [release notes](https://github.com/digitalocean/godo/releases)) * github.com/google/pprof aee1124e3a93 -> 76d1ae5aea2b (no changes pulled into vendor) * golang.org/x/tools v0.4.0 -> v0.5.0 (relating to Go compiler utilities) * google.golang.org/genproto 76db0878b65f -> 31e0e69b6fc2 * k8s.io/api v0.26.0 -> v0.26.1 (comment-only change) * k8s.io/apimachinery v0.26.0 -> v0.26.1 (no changes pulled into vendor) * k8s.io/client-go v0.26.0 -> v0.26.1 (small fixes) Special notes for your reviewer: A couple of interfaces changed; these have required matching changes in Loki code. Those changes are split into separate commits. I also note that most calls to `relabel` ignore when the rule says "drop". Maybe this is wrong?	2 years ago
Joseph Shanak	7204216187	chore: Fix typos in Helm documentation (#8593 )	2 years ago
Christian Haudum	d4a6b159fa	chore: Cleanup label extraction expression (#8596 ) The aim of this is to remove redundancy from the parser grammar and make the expression name more descriptive. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Bryan Boreham	019ac9975c	Iterators: re-implement entrySortIterator using loserTree for performance (#8351 ) What this PR does / why we need it: [Draft PR for comment at this time] This implementation uses a data structure called Loser Tree, also known as Tournament Tree, based on Knuth, "Sorting and Searching" section 5.4.1. I couldn't find an existing Loser Tree in Go, so I wrote my own; the file is 132 lines long. It uses generics in the hope it can also be applied elsewhere. One benchmark result: ``` name old time/op new time/op delta SortIterator/sort-4 3.78ms ± 4% 2.66ms ± 3% -29.54% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SortIterator/sort-4 319kB ± 0% 14kB ± 0% -95.52% (p=0.008 n=5+5) name old allocs/op new allocs/op delta SortIterator/sort-4 104 ± 0% 5 ± 0% -95.19% (p=0.008 n=5+5) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Karsten Jeschkies	eeca4589fb	Define Container for Codespaces (#8561 )	2 years ago
Susana Ferreira	b8118b1e7b	Helm enterprise-logs: update kubernetes secrets creation (#8467 ) What this PR does / why we need it: Fix the Kubernetes secrets creation for the tokengen and provisioner jobs for multiple helm installations/uninstallations. The execution flow for the helm installation is the following: 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage and writes it to the `shared` mount. 2) `tokengen` job `create-secret` container creates a new Kubernetes secret for the generated admin token. 3) `provisioner` job `provisioner` container creates the new admin resources via the Admin API and writes the tokens to the `bootstrap` mount. 4) `provisioner` job `create-secret` container creates new Kubernetes secrets for each token of the additional tenants. ## Previous implementation Uninstall and re-install the enterprise-logs helm: 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage, and writes it to the `shared` mount. This is because this job uses an [emptyDir](https://kubernetes.io/docs/concepts/storage/volumes/#emptydir) mount which is deleted once the job completes. When a new job is created, the directory will be again empty, forcing the `tokengen` to generate a new token. 2) `tokengen` job `create-secret` container fails, because an admin token secret already exists: ``` Defaulted container "create-secret" out of: create-secret, loki (init) error: failed to create secret secrets "enterprise-logs-admin-token" already exists ``` 3) The helm installation fails ❌ ## Implementation in this PR 1) `tokengen` job `loki` container generates a new admin token, stores it in the object storage, and writes it to the `shared` mount. 2) `tokengen` job `create-secret` container updates the previously created Kubernetes secret for the admin token. 3) `provisioner` job `provisioner` container checks that the admin resources already exist and doesn't write the token files to the `bootstrap` mount. 4) `provisioner` job `create-secret` container checks that the token files are not present on the `bootstrap` mount, and does not create new secrets. 5) The helm installation succeeds ✅ Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Michel Hollands	4f8d3240f6	Use 0.28.1 build image and update go and alpine versions (#8583 ) What this PR does / why we need it: - Use the 0.28.1 build image - Update Go version to 1.20.1 - Use Alpine 3.16.4 - Fix linter issues due to updated govet in 1.20.1 - Modify images to not create `/etc/nsswitch.conf` file anymore (available by default on Alpine 3.16.4) - Remove impossible test cases for `TestMemChunk_IteratorBounds`(see https://github.com/grafana/loki/pull/8591#discussion_r1115020111 for context) Signed-off-by: Michel Hollands <michel.hollands@grafana.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: DylanGuedes <djmgguedes@gmail.com>	2 years ago

1 2 3 4 5 ...

4723 Commits (10e3d80731b9dd1b9ef91d7ba841ede5ebb6ee67) All Branches Search

4723 Commits (10e3d80731b9dd1b9ef91d7ba841ede5ebb6ee67)

All Branches