apitech/loki - loki - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Trevor Whitney	8b8d2ca382	prepare changelog for 2.8 release (#8798 ) What this PR does / why we need it: Prepares the changelog for the 2.8 release	3 years ago
Karsten Jeschkies	ffb605fa85	Fix: Ensure query limits tripperware wraps frontend. (#8789 ) What this PR does / why we need it: The query frontend would not enforce the per-request query limits because the injected tripperware was wrapped after the frontend has been created. That is a bug. The order must be changed so that the `queryrange.LimitsMiddleware` runs after the `querylimits.limitsMiddleware`. Which issue(s) this PR fixes: Fixes #8790 Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Periklis Tsirakidis	52f6b8253c	operator: Add alertingrule tenant id label for all rules (#8748 )	3 years ago
Periklis Tsirakidis	cb6f7a1a77	operator: Add alerting style guide validation (#8743 ) Co-authored-by: Robert Jacob <xperimental@solidproject.de>	3 years ago
Danny Kopping	c15048b50b	Retention: add selector detail to docs (#8808 ) What this PR does / why we need it: This adds more detail around what can and cannot be used in a `selector` for retention. It was unclear whether arbitrary LogQL could be used or not; this makes it explicit. Also added some additional matchers to the examples to show that it can be combinatorial. --------- Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	3 years ago
Joel Takvorian	688a392db2	operator: Allow multiple matchers for multi-tenancy with Network tenant (#8192 )	3 years ago
Mohamed-Amine Bouqsimi	f125682802	operator: Promote AlertingRules, RecordingRules and RulerConfig from v1beta1 to v1 (#8800 )	3 years ago
Travis Patterson	83ba93c867	fix to-string for noop label filters (#8799 ) Label Filter optimizations omit `.*` label filters from the execution pipeline but intruduced a bug where those stages were also ommitted from calls to `String` on the expression. This results in unparsable queries and panics when queries are cloned via `query.String()` This PR makes `noopLabelFilter` embed matchers and inherit their `String` method just like the `StringLabelFilters` do	3 years ago
Christian Haudum	22b672986a	Revert "Implement hierarchical queues for query scheduler" (#8796 ) Reverts grafana/loki#8691 These changes caused problems with the scheduler in our dev environments. I will conduct further testing and include the reverted changes in https://github.com/grafana/loki/pull/8752	3 years ago
Danny Kopping	61311957a3	Integration Tests: allow loki logs to be optionally output in integration tests (#8793 ) What this PR does / why we need it: Debugging integration tests can be difficult without Loki's logs being output. Changing the call from `cluster.New()` to `cluster.New(true, level.WarnValue())` now allows the author the option to temporarily or permanently enable logging for their test, as well as configure a level filter to control the noise. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	3 years ago
Oren Cohen	2a1bd3da00	operator: Improve documentation for LokiStack installation with ODF Object Storage (#8792 ) Signed-off-by: Oren Cohen <ocohen@redhat.com> Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>	3 years ago
Periklis Tsirakidis	254fbf72c4	operator: Expand OLM skip range for OpenShift Logging 5.7 release (#8791 )	3 years ago
Trevor Whitney	b46e392adb	gofmt is needed for the build (#8678 ) What this PR does / why we need it: `gofmt` is needed for the build, `make format` fails without it.	3 years ago
Periklis Tsirakidis	4854e4af89	operator: Update Loki operand to v2.7.4 (#8771 )	3 years ago
Gerard Vanloo	a926ae3249	operator: Update golang to 1.20; Update dependencies to latest (#8776 )	3 years ago
Danny Kopping	33e44ed39d	Ruler: remote rule evaluation (#8744 ) What this PR does / why we need it: Adds the ability to evaluate recording & alerting rules against a given `query-frontend`, allowing these queries to be executed with all the parallelisation & optimisation that regular adhoc queries have. This is important because with `local` evaluation all queries are single-threaded, and rules that evaluate a large range/volume of data may timeout or OOM the `ruler` itself, leading to missed metrics or alerts. When `remote` evaluation mode is enabled, the `ruler` effectively just becomes a gRPC client for the `query-frontend`, which will dramatically improve the reliability of the `ruler` and also drastically reduce its resource requirements. Which issue(s) this PR fixes: This PR implements the feature discussed in https://github.com/grafana/loki/pull/8129 (LID 0002: Remote Rule Evaluation).	3 years ago
Paul Tirk	540380fa94	Promtail: fix GeoIP typo (#8783 ) What this PR does / why we need it: Fixes a typo for GeoIP stage. From `geoip_continet_name` to `geoip_continent_name`.	3 years ago
Karsten Jeschkies	28ebf8ec12	Impose per-request limit on label queries. (#8777 ) What this PR does / why we need it: #8727 introduced per-request limits. These should be enforce for label queries as well. This change adds the required middleware to all label query endpoints. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Ed Welch	0352b75f0d	Loki: Add new logql template functions `bytes`, `duration`, `unixEpochMillis`, `unixEpochNanos`, `toDateInZone`, `b64Enc`, and `b64Dec` (#8774 ) What this PR does / why we need it: This adds several new template functions to the logql to be used in `line_format` and `label_format` - bytes - duration (and duration_seconds) - unixEpochMillis - unixEpochNanos - toDateInZone - b64Enc and b64Dec `bytes` and `duration` adds parity with the `unwrap` pipeline stage in logql, allowing you to convert human readable versions of bytes and times into their respective primitives of bytes and seconds. This makes it possible to do math and comparisons of these extracted values in `line_format` and `label_format` `unixEpochMillis` and `unixEpochNanos` extends the existing `unixEpoch` function which can only generate seconds level precision to allow having millisecond and nanosecond level precision. `toDateInZone` allows for specifying a specific timezone when parsing a date. `b64Enc` and `b64Dec` allow base64 encoding and decoding values. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: @JStickler I made a lot of changes to the template_functions.md doc page to try and create some more consistency as well as remove some notices that really aren't relevant anymore: * Tried to make sure every function had a `Signature` and `Examples` block * Removed a lot of `NOTE` about functions being introduced in a specific version * Removed documentation for some deprecated string functions (they still exist in code but I removed the docs for them, their exist better replacements for all of them) Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Edward Welch <edward.welch@grafana.com>	3 years ago
Ed Welch	55c96bfe90	Loki: add lines processed to metrics.go (#8764 ) What this PR does / why we need it: Typically `throughput` and `total_bytes` are the most common fields in the `metrics.go` log line which we look at for query performance. However, there are cases where query performance is better measured by `total_lines` and `lines_per_second` (e.g. when processing a lot of high volume but relatively short log lines) and having this information in metrics.go can be very helpful. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Edward Welch <edward.welch@grafana.com>	3 years ago
Ed Welch	a4eb536fb2	Loki: remove `subqueries` from metrics.go logging and replace it with separate split and shard counters (#8761 ) What this PR does / why we need it: Currently the `metrics.go` log line emitted after every query includes a metric called "subqueries". This currently tracks the number of queries created by the split_by_time operations done in Loki, but does not include any counts for subqueries created as a result of sharding. It becomes difficult to make a single subqueries counter that gives useful information to determine how much a query is split by time and sharded by a shard factor, especially now that sharding in TSDB indexes is dynamic. This PR removes and deprecates the `subqueries` stat and instead creates a `splits` and `shards` statistic which records how much a query was split_by_time and the total number of shards created as well. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Edward Welch <edward.welch@grafana.com>	3 years ago
Karsten Jeschkies	8eac851962	Remove print statements introduced by #8727 . (#8775 )	3 years ago
Ed Welch	eadb9d2c00	Loki: Change the behavior of the 0 value for retention_period to disable retention. (#8753 ) What this PR does / why we need it: Issue #8359 exposed a very unfortunate inconsistency in a Loki config where the zero value did not disable a feature. By convention in Loki the zero value for a config typically "disables" it. This PR changes the retention_period to honor the zero value of `0` or `0s` to disable retention. Which issue(s) this PR fixes: Fixes #8359 Special notes for your reviewer: Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Edward Welch <edward.welch@grafana.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	3 years ago
Danny Kopping	e2ac2d50e2	Changes from linter (#8769 ) What this PR does / why we need it: We had a few outstanding linter issues, and running `make lint` fixes them all automatically. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	3 years ago
Danny Kopping	56fbb3b771	Expand `which-release.sh` to cover weekly builds as well (#8768 ) What this PR does / why we need it: Expanding tool introduced in https://github.com/grafana/loki/pull/8706 Special notes for your reviewer: Knowing which, if any, weekly builds the commit is in can also be useful. Signed-off-by: Danny Kopping <danny.kopping@grafana.com>	3 years ago
Callum Styan	5a85f6647e	Add initial implementation of per-query limits (#8727 ) What this PR does / why we need it: Sometimes we want to limit the impact of a single query by imposing limits that are stricter than the current tenant limit. E.g. the maximum query length could be seven days but based on the query or an admins decision a query should just have a maximum length of one day. This is where per-request limits come into play. They are passed via the `X-Loki-Query-Limit` header and extracted into the requests context. It is the responsibility of the operator or admin that the header is valid. Which issue(s) this PR fixes: Fixes #8762 Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	3 years ago
Michel Hollands	10e3d80731	Fix distributor latency panel (#8760 ) What this PR does / why we need it: https://github.com/grafana/loki/pull/8247 changes a metric generated by a recording rule. This fixes the "Distributor Panel" to use this different metric. Tested by changing the "Distributor Panel" manually to see it showed results. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Danny Kopping	0bf0b6b718	Modify debug loki build to work on any architecture, including ARM (#8758 ) What this PR does / why we need it: On my M1 Pro, `make loki-debug-image` produces the following output: ```bash qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory ``` This is because we run `delve` as the entrypoint for the debug image, and `delve` is being copied from `loki-build-image` which is exclusively built as `amd64` (we should make this a multi-arch image... created https://github.com/grafana/loki/issues/8759). This change will work with whichever host OS is building the image and download `delve` using that architecture instead of relying on the `loki-build-image` version.	3 years ago
Michel Hollands	15fda6bf39	Change severity of PromtailFileMissing alert to warning (#8757 ) The PromtailFileMissing alert is not critical. This changes it to a warning. Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Michel Hollands	1c4dd6ad40	Use changed metric in operational dashboard (#8749 ) What this PR does / why we need it: The metric `job_route` was changed to `cluster_job_route` in https://github.com/grafana/loki/pull/8247. This PR updates this metric in the operational dashboard. Checklist - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	3 years ago
Travis Patterson	9ac33e216e	Reimplement Unpack in terms of jsonparser rather than jsoniter (#8739 ) This PR reimplements the functionality of `Unpack` using the `jsonparser` library rather than `jsoniter` Benchmarks: ``` name old time/op new time/op delta _Parser/unpack/no_labels_hints-8 900ns ± 4% 309ns ± 3% -65.62% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 1.06µs ±12% 0.32µs ± 2% -69.72% (p=0.000 n=9+10) _Parser/unpack-not_json_line/no_labels_hints-8 37.5ns ± 8% 10.6ns ± 3% -71.70% (p=0.000 n=9+9) _Parser/unpack-not_json_line/labels_hints-8 39.6ns ±11% 10.3ns ± 2% -74.00% (p=0.000 n=10+9) name old alloc/op new alloc/op delta _Parser/unpack/no_labels_hints-8 536B ± 0% 80B ± 0% -85.07% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 536B ± 0% 80B ± 0% -85.07% (p=0.000 n=10+10) _Parser/unpack-not_json_line/no_labels_hints-8 0.00B 0.00B ~ (all equal) _Parser/unpack-not_json_line/labels_hints-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta _Parser/unpack/no_labels_hints-8 17.0 ± 0% 4.0 ± 0% -76.47% (p=0.000 n=10+10) _Parser/unpack/labels_hints-8 17.0 ± 0% 4.0 ± 0% -76.47% (p=0.000 n=10+10) _Parser/unpack-not_json_line/no_labels_hints-8 0.00 0.00 ~ (all equal) _Parser/unpack-not_json_line/labels_hints-8 0.00 0.00 ~ (all equal) ```	3 years ago
Travis Patterson	9c6e509a6a	Reimplement JsonExpressionParser in terms of jsonparser (#8734 ) This PR reimplements the functionality of `JSONExpressionParser` using the `jsonparser` library rather than `jsoniter` Benchmarks: ``` benchstat json_expression_old.txt json_expression_new.txt name old time/op new time/op delta JsonExpressionParser/json-expression-8 4.15µs ± 4% 0.82µs ± 3% -80.17% (p=0.000 n=10+10) name old alloc/op new alloc/op delta JsonExpressionParser/json-expression-8 1.07kB ± 0% 0.02kB ± 0% -97.76% (p=0.000 n=10+10) name old allocs/op new allocs/op delta JsonExpressionParser/json-expression-8 72.0 ± 0% 2.0 ± 0% -97.22% (p=0.000 n=10+10) ```	3 years ago
Christian Haudum	4b74a5b815	Implement hierarchical queues for query scheduler (#8691 ) ### What this PR does / why we need it: This PR is the first step towards hierarchical queues within the query scheduler. Hierarchical queues can be used to ensure query fairness across multiple actors within a single tenant, such as individual (human) users using the same tenant. The change is described in the LID ["Query fairness across users within tenants"](https://grafana.com/docs/loki/next/lids/0003-queryfairnessinscheduler/). * Extract metrics for `RequestQueue` into their own `metrics` field, so that they can extended and passed more easily in the future. * Move mapping for tenant queues into its own data structure (ordered map) so its functionality can be reused. It also simplifies the code inside the `tenantQueues` struct. * Add the `LeafQueue` struct that implements hierarchical queues. Sub-queues are dequeued in a round-robin manner using the same implementation of `Mapping` that is also used by the tenant queues. ### Special notes for your reviewer Part of https://github.com/grafana/loki/pull/8585 Contains the changes from PR https://github.com/grafana/loki/pull/8722 This PR does not yet make use of the new hierarchical queues, it only adds the relevant data structures. Wiring up will be done in a follow up PR. While the new `Mapping` data structure adds an unsignificant overhead to the time/op I consider the simplification an overall better tradeoff. ```console $ benchstat scheduler-bench-old.txt scheduler-bench-new.txt name old time/op new time/op delta GetNextRequest-8 18.0µs ± 2% 20.5µs ± 3% +13.89% (p=0.008 n=5+5) QueueRequest-8 56.6µs ± 0% 53.5µs ± 3% -5.48% (p=0.008 n=5+5) name old alloc/op new alloc/op delta GetNextRequest-8 1.60kB ± 0% 1.60kB ± 0% ~ (all equal) QueueRequest-8 35.6kB ± 0% 29.8kB ± 0% -16.37% (p=0.008 n=5+5) name old allocs/op new allocs/op delta GetNextRequest-8 100 ± 0% 100 ± 0% ~ (all equal) QueueRequest-8 819 ± 0% 806 ± 0% -1.59% (p=0.008 n=5+5) ``` #### Complexity of operations \| Operation \| Function \| Complexity \| \| --------- \| -------- \| ---------- \| \| Insert \| `Put(key string, value tenantQueue) bool` \| `O(1)`\| \| Select \| `GetNext(idx QueueIndex) tenantQueue` \| `O(1)` (best case) `O(n)` (worst case) \| \| Remove \| `Remove(key string) bool` \| `O(1)` \| --- Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	3 years ago
Sandeep Sukhani	162a2d0057	deletion: fix issue in processing delete requests with tsdb index (#8665 ) What this PR does / why we need it: When a delete request creates a new chunk from an existing chunk, we index it to the index store. In TSDB, we [drop](`944b488bd2/pkg/storage/stores/tsdb/head_manager.go (L235-L237)`) `__name__` label, which was being added to chunkrefs for historical reasons. However, this was not done while indexing chunks from the deletion code, causing deletion to fail with the error [chunk insertion is only allowed on existing streams](`619c2212f5/pkg/storage/stores/tsdb/builder.go (L67)`). This PR handles the issue by dropping the `__name__` label and adding relevant tests. Special notes for your reviewer: I will add an integration test for deletion with TSDB once we have PR https://github.com/grafana/loki/pull/7754 merged since it does some groundwork to run integration tests with both `boltdb-shipper` and `tsdb`. Checklist - [x] Tests updated - [x] `CHANGELOG.md` updated	3 years ago
dependabot[bot]	466a32192a	operator: Bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 (#8726 ) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 years ago
Dylan Guedes	ea6abbfd07	Loki-Mixin: Remove query-readiness panel (#8735 ) What this PR does / why we need it: Remove from loki-mixin the panel that shows the query_readiness metric. The metric was removed a while ago.	3 years ago
J Stickler	673bfd603b	Fixing broken link (404) (#8688 ) This was reported to the docs team via Slack. Fixing broken link from Promtail Scraping file to Promtail Configuration file.	3 years ago
Danny Kopping	6c0f3442cc	Tools: add tool to determine which release (if any) a commit appears in (#8706 ) I've often found myself needing to determine which release a particular PR appears in. This tool makes that easy, and it accepts the merge commit ref of the PR. Example from https://github.com/grafana/loki/pull/7044, in which [a user is asking which version this feature appears in](https://github.com/grafana/loki/pull/7044#issuecomment-1455694087). ```bash $ ./tools/which-release.sh `93a5a71` Commit was found in the following releases: release-2.7.x ```	3 years ago
Dylan Guedes	656ad800fe	Promtail: Stop ticker to avoid leaking (#8695 ) What this PR does / why we need it: Call `Stop` to positions ticker to release associated resources/avoid leaking.	3 years ago
Mohamed-Amine Bouqsimi	519e25c714	operator: Fix gateway's nodeSelector and tolerations (#8707 )	3 years ago
Libby Anderson	06db3b96bb	Update retention_support.md (#8342 ) Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	3 years ago
Karsten Jeschkies	28d845d26c	Make Loki Overrides public. (#8696 ) What this PR does / why we need it: Follow up to #8689 that will allow to inject a different overrides implementation. Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Callum Styan <callumstyan@gmail.com>	3 years ago
Travis Patterson	7f42137584	Use Line Filters in StringLabelFilter (#8659 ) We've done a ton of work to optimize regexes in line filters but nothing in label filters. To avoid duplicating the work or reworking all of our filter types, this PR creates a new label filter that has an optimized line filter. It uses that against the label value to determine if they match. Note on Benchmarks: the input string for this is 1114195 bytes long. The `not` test tells us that our approach is quite a lot slower when the literal pattern isn't present in the input. The size of the input really emphasizes it. Benchmarks: ``` name old time/op new time/op delta LineLabelFilters/foo-8 50.6ns ± 9% 14.3ns ± 1% -71.67% (p=0.000 n=10+8) LineLabelFilters/not-8 15.7ns ± 1% 64165.6ns ± 2% +407766.77% (p=0.000 n=10+10) LineLabelFilters/(foo)-8 58.4ns ± 1% 14.8ns ±10% -74.68% (p=0.000 n=9+9) LineLabelFilters/(foo\|ba)-8 64.9ns ± 0% 18.2ns ± 2% -71.90% (p=0.000 n=7+9) LineLabelFilters/(foo\|ba\|ar)-8 74.8ns ± 7% 21.4ns ± 2% -71.42% (p=0.000 n=10+8) LineLabelFilters/(foo\|(ba\|ar))-8 65.1ns ± 1% 18.1ns ± 2% -72.22% (p=0.000 n=8+8) LineLabelFilters/foo.-8 882ns ± 4% 15ns ±11% -98.30% (p=0.000 n=9+10) LineLabelFilters/.foo-8 11.5ns ± 8% 14.9ns ± 7% +30.39% (p=0.000 n=10+10) LineLabelFilters/.foo.-8 5.46µs ± 7% 0.01µs ± 3% -99.74% (p=0.000 n=10+9) LineLabelFilters/(.)(foo).-8 6.26µs ± 7% 0.01µs ± 2% -99.77% (p=0.000 n=10+9) LineLabelFilters/(foo.\|.ba)-8 5.58µs ± 3% 0.02µs ± 8% -99.67% (p=0.000 n=9+10) LineLabelFilters/(foo.\|.bar.)-8 7.02µs ± 7% 0.02µs ± 8% -99.73% (p=0.000 n=10+10) LineLabelFilters/.foo.\|bar-8 5.53µs ± 6% 0.02µs ± 2% -99.67% (p=0.000 n=10+8) LineLabelFilters/.foo\|bar-8 3.73µs ± 6% 0.02µs ± 3% -99.52% (p=0.000 n=10+9) LineLabelFilters/(?:.foo.\|bar)-8 5.43µs ± 8% 0.02µs ± 8% -99.65% (p=0.000 n=10+10) LineLabelFilters/(?P<foo>.foo.\|bar)-8 5.71µs ± 3% 0.02µs ±10% -99.68% (p=0.000 n=9+9) LineLabelFilters/.foo.\|bar\|buzz-8 5.34µs ± 2% 0.02µs ± 3% -99.65% (p=0.000 n=10+9) LineLabelFilters/.foo.\|bar\|uzz-8 5.36µs ± 1% 0.02µs ± 3% -99.60% (p=0.000 n=8+8) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 68.8ns ± 8% 22.6ns ± 7% -67.19% (p=0.000 n=10+10) LineLabelFilters/f\|foo\|foobar-8 77.1ns ± 1% 18.6ns ± 9% -75.90% (p=0.000 n=8+10) LineLabelFilters/f.\|foobar.\|.buzz-8 5.64µs ± 7% 0.02µs ±10% -99.60% (p=0.000 n=10+10) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 6.29µs ± 8% 0.02µs ±10% -99.65% (p=0.000 n=10+10) LineLabelFilters/.-8 963ns ± 8% 2ns ±14% -99.77% (p=0.000 n=10+10) LineLabelFilters/.\|.-8 4.46µs ± 8% 0.00µs ± 8% -99.95% (p=0.000 n=10+10) LineLabelFilters/.\|\|\|\|-8 2.99µs ± 1% 0.00µs ±16% -99.93% (p=0.000 n=8+10) LineLabelFilters/#00-8 43.5ns ± 8% 2.1ns ± 1% -95.25% (p=0.000 n=10+8) LineLabelFilters/(?i)foo-8 71.7ns ± 6% 13.1ns ± 1% -81.73% (p=0.000 n=10+8) LineLabelFilters/(?i)界-8 16.5ns ± 8% 150.2ns ± 8% +809.55% (p=0.000 n=10+10) LineLabelFilters/(?i)ïB-8 23.8ns ± 1% 14748979.8ns ± 7% +62074730.81% (p=0.000 n=8+10) LineLabelFilters/(?:)foo\|fatal\|exception-8 185ns ± 2% 21ns ± 2% -88.38% (p=0.000 n=9+8) LineLabelFilters/(?i)foo\|fatal\|exception-8 78.4ns ± 3% 20.2ns ± 2% -74.23% (p=0.000 n=9+9) LineLabelFilters/(?i)f\|foo\|foobar-8 94.3ns ±16% 15.4ns ± 9% -83.66% (p=0.000 n=10+10) LineLabelFilters/(?i)f\|fatal\|e.-8 65.7ns ± 5% 18.2ns ± 3% -72.24% (p=0.000 n=9+8) LineLabelFilters/(?i).foo.-8 6.04µs ± 8% 0.01µs ± 2% -99.78% (p=0.000 n=10+10) name old alloc/op new alloc/op delta LineLabelFilters/foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/not-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00B 0.00B ~ (all equal) LineLabelFilters/#00-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)界-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00B 0.00B ~ (all equal) LineLabelFilters/(?i).foo.-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta LineLabelFilters/foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/not-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|ba\|ar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo\|(ba\|ar))-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(.)(foo).-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.ba)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(foo.\|.bar.)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo\|bar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?P<foo>.foo.\|bar)-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.foo.\|bar\|uzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/foo\|bar\|b\|buzz\|zz-8 0.00 0.00 ~ (all equal) LineLabelFilters/f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/f.\|foobar.\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/((f.)\|foobar.)\|.buzz-8 0.00 0.00 ~ (all equal) LineLabelFilters/.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|.-8 0.00 0.00 ~ (all equal) LineLabelFilters/.\|\|\|\|-8 0.00 0.00 ~ (all equal) LineLabelFilters/#00-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)界-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)ïB-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?:)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)foo\|fatal\|exception-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|foo\|foobar-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i)f\|fatal\|e.-8 0.00 0.00 ~ (all equal) LineLabelFilters/(?i).foo.*-8 0.00 0.00 ~ (all equal) ```	3 years ago
Dylan Guedes	f9a1f2d94e	Loki: Stop running tickers on deletes (#8697 ) What this PR does / why we need it: Calls `ticker.Stop()` to avoid leaking ticker resources for `GenNumberLoader` and `deleteRequestsClient`.	3 years ago
Callum Styan	9a2a038f43	Allow passing of context to query related limits functions (#8689 ) In this PR we're allowing for passing of a `context.Context` via the Limits interfaces (some of which are new, to clean up hardcoding/embedding of `validation.Overrides`) This is based on work/ideas by @jeschkies . Fixes #8694 --------- Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>	3 years ago
Kaviraj Kanagaraj	371455770f	doc(best-practices): Update default value of `max_chunk_age`. (#8685 )	3 years ago
e0031374	2dcaba3176	Loki Getting Started: Fix example query that was not working (#8668 ) What this PR does / why we need it: Previously example query was `evaluate-loki_flog_1` this was not the label used in flog. This results in query not returning any logs which beginners may be unsure of the cause of the issue. This might also be an issue if flog was running in the background and logs are not displayed. Changed to `evaluate-loki-flog-1`. Which issue(s) this PR fixes: Fixes #<issue number> Special notes for your reviewer: Trivial fix to "Getting Started" documentation Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Danny Kopping	ab7a970b94	Querier/Ruler: add histogram to track fetched chunk size distribution (#8682 ) What this PR does / why we need it: We are looking at making some changes to the chunk caching strategy, and we need this data to know what size chunks we're typically requesting. For example, if the overwhelming majority of chunks are small we may decide to cache only small chunks to decrease the number of requests to the object store; we could fit more chunks in cache this way, which may have a positive performance impact.	3 years ago
Bryan Boreham	08ac5336d5	WAL: store pointers in record pool (#8667 ) What this PR does / why we need it: Storing a slice in `sync.Pool` wastes 24 bytes every time it is returned to the heap; see https://staticcheck.io/docs/checks#SA6002 Storing a pointer to a slice allows the Pool to work without waste. This came up in discussion about the benchmark in #8489 - with this change the memory usage comes down: ``` name old time/op new time/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 7.37ms ±13% 7.45ms ± 9% ~ (p=0.841 n=5+5) name old alloc/op new alloc/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 727kB ± 0% 679kB ± 0% -6.63% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Writer_WriteEntries/1000_lines,_1_different_label_sets-4 12.0k ± 0% 10.0k ± 0% -16.68% (p=0.000 n=5+4) ``` Checklist - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required) - NA Documentation added - [x] Tests updated - NA `CHANGELOG.md` updated - NA Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	3 years ago
Travis Patterson	c42a0ba868	Optimize .+ regex line filter (#8646 ) Interpolated variables from Grafana dashboards may result in the regex matcher `.+`. Filters with `+` are already being rewritten to be non greedy but there is a further optimization to make replace the regex altogether with a filter that just matchers `len(line) > 0`	3 years ago

1 2 3 4 5 ...

4749 Commits (8b8d2ca382d29c0d5612dee956dfe48ae2b51d10) All Branches Search

4749 Commits (8b8d2ca382d29c0d5612dee956dfe48ae2b51d10)

All Branches