4861 Commits (bf2e712b32f4e8975d8c81ce27a5e6149c775ba8)

 

All Branches   

Search

Author	SHA1	Message	Date
Trevor Whitney	bf2e712b32	I do not think we have circleci jobs anymore (#9002)	2 years ago
Alan Conway	6532f5d668	operator: Restore minimum PVC sizes for 1x.extra-small (#9005)	2 years ago
Periklis Tsirakidis	2ae80d7166	Align common instance_addr with memberlist advertise_addr (#8959)	2 years ago
Trevor Whitney	5113906c67	Update helm and jsonnet for 2.8 release (#9003) ... Prepare helm and jsonnet for 2.8 release.	2 years ago
Trevor Whitney	e82885da50	Change loki version in docs for 2.8 release (#8985) ... Changes version references in Loki docs for the upcoming release Also adds a script for diffing metrics when doing a release.	2 years ago
Shweta Padubidri	8b669ff651	operator: Enhancement Proposal for Zone Aware Replication (#8381) ... Signed-off-by: Shweta Padubidri <spadubid@redhat.com>	2 years ago
Owen Diehl	62403350a5	remove redundant splitby middleware (#8996) ... Found this double-copied line which a mistake. This PR removes one of them which won't change behavior (besides removing duplicate spans/etc).	2 years ago
René Scheibe	46af2cdcf1	Promtail: Prevent logging errors on normal shutdown (#8988) ... **What this PR does / why we need it**: Since PR #4066 two messages are logged for the errors `ErrExpired` and `EOF`, whereas nothing has been logged beforehand. As `ErrExpired` is returned by the `JournalReader` after sending a message to the `until` channel to signal a normal stop, this should not be logged as an error.	2 years ago
pixiono	e2c4454a2d	Fix dns-port in network-policy (#8733) ... **What this PR does / why we need it**: Currently the port for DNS is hardcoded in the network policy which causes problems in our setup because we use a different port for this. However, since the coredns pod always names the port "dns" we could use this name. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Andrii Kushch	9f41182da2	Fix the link in the Azure Event Hubs doc (#8904) ... **What this PR does / why we need it**: This PR fixes the link to the configuration in the Azure Event Hubs scraping doc. Link to the discussion https://github.com/grafana/loki/pull/8787#discussion_r1145298591 **Which issue(s) this PR fixes**: Not available **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
pixiono	c4d016fd53	Add projected volume type to psp (#8747) ... **What this PR does / why we need it**: When I tried to use an S3 bucket as storage and access it using an IAM role, I got the following event: > 27s Warning FailedCreate statefulset/loki-read create Pod loki-read-0 in StatefulSet loki-read failed error: pods "loki-read-0" is forbidden: PodSecurityPolicy: unable to admit pod: [spec.volumes[0]: Invalid value: "projected": projected volumes are not allowed to be used This can be simply solved with this PR. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Sandeep Sukhani	1fcefe8efa	index-gateway: fix failure in initializing index gateway when boltdb-shipper is not being used (#8755) ... **What this PR does / why we need it**: When only `tsdb` index is being used in the schema without configuring `boltdb-shipper` index store, we fail to initialize `index-gateway` since it also tries to build `boltdb-shipper` index client. This reference is used for serving `QueryIndex` calls which are for serving index from boltdb files. This PR fixes the issue by adding a check for the existence of `boltdb-shipper` in the schema config before initializing an index client. On the index gateway side, it adds a `failingIndexClient`, which errors when someone tries to query it. **Checklist** - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Travis Patterson <masslessparticle@gmail.com> Co-authored-by: Dylan Guedes <djmgguedes@gmail.com> Co-authored-by: Travis Patterson <travis.patterson@grafana.com>	2 years ago
Andrey Em	0f98b45d8d	Loki: Add UsageStatsURL to usagestats Config (#8779) ... **What this PR does / why we need it**: Reports used to be sent to a fixed URL usageStatsURL. Now this url can be configurable while using the old url as a default. Updated tests to use config for custom URLs instead of changing package variable. **Which issue(s) this PR fixes**: Fixes #6502 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
dependabot[bot]	82a1f23ac9	Bump helm/chart-testing-action from 2.3.1 to 2.4.0 (#8907) ... Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.3.1 to 2.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/helm/chart-testing-action/releases">helm/chart-testing-action's releases</a>.</em></p> <blockquote> <h2>v2.4.0</h2> <h2>What's Changed</h2> <ul> <li>Retry artifact downloads by <a href="https://github.com/steven-sheehy"><code>@​steven-sheehy</code></a> in <a href="https://redirect.github.com/helm/chart-testing-action/pull/111">helm/chart-testing-action#111</a></li> <li>fix example workflow by <a href="https://github.com/CrowdSalat"><code>@​CrowdSalat</code></a> in <a href="https://redirect.github.com/helm/chart-testing-action/pull/115">helm/chart-testing-action#115</a></li> <li>docs: only run chart lint if changed by <a href="https://github.com/fty4"><code>@​fty4</code></a> in <a href="https://redirect.github.com/helm/chart-testing-action/pull/106">helm/chart-testing-action#106</a></li> <li>docs: use GITHUB_OUTPUT in example workflow by <a href="https://github.com/fty4"><code>@​fty4</code></a> in <a href="https://redirect.github.com/helm/chart-testing-action/pull/107">helm/chart-testing-action#107</a></li> <li>Use cosign to verify the release and update chart-testing to v3.8.0 by <a href="https://github.com/cpanato"><code>@​cpanato</code></a> in <a href="https://redirect.github.com/helm/chart-testing-action/pull/116">helm/chart-testing-action#116</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/steven-sheehy"><code>@​steven-sheehy</code></a> made their first contribution in <a href="https://redirect.github.com/helm/chart-testing-action/pull/111">helm/chart-testing-action#111</a></li> <li><a href="https://github.com/CrowdSalat"><code>@​CrowdSalat</code></a> made their first contribution in <a href="https://redirect.github.com/helm/chart-testing-action/pull/115">helm/chart-testing-action#115</a></li> <li><a href="https://github.com/fty4"><code>@​fty4</code></a> made their first contribution in <a href="https://redirect.github.com/helm/chart-testing-action/pull/106">helm/chart-testing-action#106</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/helm/chart-testing-action/compare/v2...v2.4.0">https://github.com/helm/chart-testing-action/compare/v2...v2.4.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="e878887317"><code>e878887</code></a> Use cosign to verify the release and update chart-testing to v3.8.0 (<a href="https://redirect.github.com/helm/chart-testing-action/issues/116">#116</a>)</li> <li><a href="68148c920a"><code>68148c9</code></a> docs: use GITHUB_OUTPUT in example workflow (<a href="https://redirect.github.com/helm/chart-testing-action/issues/107">#107</a>)</li> <li><a href="b567af86ba"><code>b567af8</code></a> docs: only run chart lint if changed (<a href="https://redirect.github.com/helm/chart-testing-action/issues/106">#106</a>)</li> <li><a href="4c22ea3887"><code>4c22ea3</code></a> fix example workflow (<a href="https://redirect.github.com/helm/chart-testing-action/issues/115">#115</a>)</li> <li><a href="a153a59efc"><code>a153a59</code></a> Retry artifact downloads (<a href="https://redirect.github.com/helm/chart-testing-action/issues/111">#111</a>)</li> <li>See full diff in <a href="https://github.com/helm/chart-testing-action/compare/v2.3.1...v2.4.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Anton Patsev	a4aeb0e651	Update rbac.authorization.k8s.io/v1beta1 to rbac.authorization.k8s.io/v1 (#8270) ... rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole Signed-off-by: Anton Patsev <patsev.anton@gmail.com> Which of these should I fill out in this PR ? **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Anton Patsev <patsev.anton@gmail.com>	2 years ago
Erik Sjölund	2cccc1bc68	Docs: Fix typos and grammar (#8966) ... **What this PR does / why we need it**: Fixes typos and grammar. Most of them were occurrences of `it's` that should be `its`. **Which issue(s) this PR fixes**: None **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>	2 years ago
Gábor Farkas	09f23ecd03	Docs: Improve time range documentation (#8847) ... **What this PR does / why we need it**: Describes how exactly the `start` and `end` timestamps operate on the time range boundaries. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Bill Franklin	b88aa08d89	Loki Canary: Enable insecure-skip-verify for all requests (#8869) ... **What this PR does / why we need it**: This supports cases where the cert cannot be trusted but we are not using mTLS, i.e. `loki-canary -tls=true -insecure=true` **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Danny Kopping	8233a1560a	Adding release cadence docs (#8893) ... **What this PR does / why we need it**: Members of our community often ask about our release cadence, so I have documented it for easy future reference. --------- Signed-off-by: Danny Kopping <danny.kopping@grafana.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Ed Welch	7264e0ef53	Loki: Remove global singleton of the tsdb.Store and keep it scoped to the storage.Store (#8928) ... **What this PR does / why we need it**: I made this change to fix an issue with the cmd/migrate tool which I'm also sneaking a few fixes on in this PR too. We had a global singleton of the tsdb.Store which was leading to the migrate tool reading from and writing to the `source` storage.Store because it created the singleton with an object store client only pointing to the source store. This PR changes the scoping of that singleton to not be global but instead local to each instance of storage.Store **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Edward Welch <edward.welch@grafana.com>	2 years ago
Alfredo	f3a49f4734	Update contains and hasPrefix/hasSuffix with the correct examples (#8929) ... **What this PR does / why we need it**: WHAT: - Update examples for `contains` and `hasSuffix` - Correct order should be `functionName arg1 arg2 argN`, eg. `contains s src` WHY: - Current example for `contains` and `hasPrefix` / `hasSuffix` has a wrong order that will cause `TemplateFormatErr`. - Examples I'm referring to `{{ if .err hasSuffix "Timeout" }} timeout {{end}}` **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
chrisharbro	9efbd5ca45	typo and phrasing (#8942) ... The first sentence doesn't sound natural, tried to massage it to have a more natural sound. Fixed a minor typo.	2 years ago
Trevor Whitney	f9c90a0e43	Diff configs script (#8944) ... **What this PR does / why we need it**: I always forget this trick for diffing configs when preparing a new release so I added it to a script.	2 years ago
Alan Conway	75ec3f3386	Redefine 1x.extra-small to have 0 requirements. (#8977) ... Remove resource requirements so lokistack can run on laptop-sized SNO or CRC clusters. Originally I thought to add an even smaller size, but I see that 1x.extra-small is already documented as not-for-production, so it seems appropriate. Doc comment: // SizeOneXExtraSmall defines the size of a single Loki deployment // with NO resource requirements and without HA support. // // This is ONLY for development, testing, or demos // on limited single-node clusters. // There are NO performance guarantees. // LokiStack will use whatever resources are available, // and WILL NOT FUNCTION CORRECTLY if there is not enough memory or CPU. // // DO NOT USE THIS IN PRODUCTION!	2 years ago
李国忠	73f9ece867	[doc] client : ilogtail loki integration (#8970) ... **What this PR does / why we need it**: https://github.com/alibaba/ilogtail/pull/685 ilogtail is a very popular log agent in China, with tens of millions of installations. The open source community of ilogtail has completed the integration of loki. This PR is completed as a supplement to loki doc demo config，Type: flusher_loki ```yaml enable: true inputs: - Type: file_log LogPath: . FilePattern: simple.log flushers: - Type: flusher_loki URL: http://localhost:3100/loki/api/v1/push ExternalLabels: source: ilogtail ``` **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: flusher_loki PR snapshot  **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Ed Welch	b892cade6a	Loki: Fixes incorrect query result when querying with start time == end time (#8979) ... **What this PR does / why we need it**: In several places within Loki we need to determine if a query is a `range query` or `instant query`, this is done by checking to see if the start and end time are equal **and** the `step=0` The downstream handler was not checking for `step=0` and thus it incorrectly mapped a range query to an instant query when a query has a start time equal to and end time. There are a few other things at play here, mainly that we should really error anytime someone tries to run an instant query for logs which would have exposed this error much more easily. But that's something I'd like to handle in a different PR as it will be considered a breaking change depending on how we do it. This PR uses an existing function we have for testing the query type and addresses the issue found in #8885 **Which issue(s) this PR fixes**: Fixes #8885 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Edward Welch <edward.welch@grafana.com>	2 years ago
Ed Welch	edc6b0bff7	Loki: Add a limit for the [range] value on range queries (#8343) ... Signed-off-by: Edward Welch <edward.welch@grafana.com> **What this PR does / why we need it**: Loki does not currently split queries by time to a value smaller than what's in the [range] of a range query. Example ``` sum(rate({job="foo"}[2d])) ``` Imagine now this query being executed over a longer window of a few days with a step of something like 30m. Every step evaluation would query the last [2d] of data. There are use cases where this is desired, specifically if you force the step to match the value in the range, however what is more common is someone accidentally uses `[$__range]` in here instead of `[$__interval]` within Grafana and then sets the query time selector to a large value like 7 days. This PR adds a limit which will fail queries that set the [range] value higher than the configured limit. It's disabled by default. In the future it may be possible for Loki to perform splits within the [range] and remove the need for this limit, but until then this can be an important safeguard in clusters with a lot of data. **Which issue(s) this PR fixes**: Fixes #8746 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Signed-off-by: Edward Welch <edward.welch@grafana.com> Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com> Co-authored-by: Vladyslav Diachenko <82767850+vlad-diachenko@users.noreply.github.com>	2 years ago
Sandeep Sukhani	69d6ee293e	tsdb: use unique uploader name while building tsdb index filename, same as boltdb-shipper (#8975) ... **What this PR does / why we need it**: While building file names from `boltdb-shipper` and `tsdb`, we add the name of the uploader to it. To avoid collisions in filenames when running multiple ingesters with the same name, we also add a nanosecond precise timestamp to the ingester name, which is persistent as the uploader name in the active index directory. This is not being done for the tsdb index built from ingesters which can cause collisions in filenames when running multiple ingesters with the same name. I have moved the code to manage the uploader name to the index shipper config and used the same to share it with tsdb.	2 years ago
Dylan Guedes	9159c1dac3	Loki: Improve spans usage (#8927) ... **What this PR does / why we need it**: - At different places, inherit the span/spanlogger from the given context instead of instantiating a new one from scratch, which fix spans being orphaned on a read/write operation. - At different places, turn spans into events. Events are lighter than spans and by having fewer spans in the trace, trace visualization will be cleaner without losing any details. - Adds new spans/events to places that might be a bottleneck for our writes/reads.	2 years ago
Danny Kopping	de84737368	Fix fetched chunk from store size in metric (#8971) ... **What this PR does / why we need it**: The `Size()` function on `chunk.Chunk` calls out to `func (ChunkRef) Size() int` in the proto, which doesn't actually include the size of the chunk data! We need to call `chunk.Data.Size()` for that.	2 years ago
Suruthi-G-K	e7b0d4d26e	feat(cos): Support authentication with trusted profiles (#8939) ... **What this PR does / why we need it**: Add trusted profile authentication in COS client **Which issue(s) this PR fixes**: Fixes NA **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: shahulsonhal <shahulsonhal@gmail.com> Co-authored-by: tareqmamari <tariq.mamari@de.ibm.com>	2 years ago
Danny Kopping	6bb8a071ca	Querier: block query by hash (#8953) ... **What this PR does / why we need it**: Using the [query blocker](https://grafana.com/docs/loki/next/operations/blocking-queries/) can be unergonomic since queries can be long, require escaping, or hard to copy from logs. This change enables an operator to block queries by their hash.	2 years ago
Karsten Jeschkies	0030cafb16	Remove dedupe cache from operations documentation. (#8957)	2 years ago
Periklis Tsirakidis	1bcf683513	Expose optional label matcher for label values handler (#8824)	2 years ago
Grot (@grafanabot)	b97525a448	[CI/CD] Update yaml file `./production/helm/loki/values.yaml` (+1 other) (#8955) ... **Here is a summary of the updates contained in this PR:** *** Update attribute `$.enterprise.version` in yaml file `./production/helm/loki/values.yaml` to the following value: `v1.6.3` *** Bump version of Helm Chart Add changelog entry to `./production/helm/loki/CHANGELOG.md` Re-generate docs	2 years ago
Salva Corts	28a7733ede	Rename config for enforcing a minimum number of label matchers (#8940) ... **What this PR does / why we need it**: Followup PR for https://github.com/grafana/loki/pull/8918 renaming config. See https://github.com/grafana/loki/pull/8918/files#r1151820792. **Which issue(s) this PR fixes**: Fixes https://github.com/grafana/loki-private/issues/699 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Christian Haudum	abc0fd26d2	Enforce per tenant queue size (#8947) ... **What this PR does / why we need it**: Prior to the changes in https://github.com/grafana/loki/pull/8752 the max queue size per tenant was enforced by the size of the buffered channel to which a request was enqueued. However, since we have hierarchical queues, every sub-queue has the same channel capacity as the root (tenant) queue. Therefore the total queue size per tenant needs to be tracked separately, so requests can be rejected when the max queue size is reached. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Christian Haudum	0adedfa689	Revert high cardinality metric in scheduler (#8946) ... **What this PR does / why we need it**: The metrics was useful for initial testing of the new scheduler queue implementation but yields high cardinality metrics, which is not desired. Also, the metric does not add additional value beyond the initial testing phase. **Special notes for your reviewer**: The metric was introduced with commit cba31024d4 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>	2 years ago
Pablo	89996c9714	Promtail WAL support: Implement reader side (#8302) ... **What this PR does / why we need it**: This PR is the second in a series that will implement WAL support into Promtail. The main objective of this PR is implement the reader side of WAL. That is, using the previously instantiated `client.Manager` to somehow read entries from the WAL instead of receiving them from a channel. **Pending work**: - [x] Implement mechanism so that `WriteTo` targets of each `wal.Watcher` can cleanup un-used series - [x] Write a full fledged test-case that tests a WAL enabled Promtail (maybe in a follow up) **Which issue(s) this PR fixes**: Part of #8197 **Special notes for your reviewer**: The line count might be big since this PR implements two fully fledged test cases of Promtail with WAL enabled. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Periklis Tsirakidis	b76be36e0c	operator: Fix makefile target operatorhub (#8930)	2 years ago
Karsten Jeschkies	43ae1db14c	Give examples for all cache configurations. (#8832) ... **What this PR does / why we need it**: #8373 documented how to setup Memcached for caching. The documentation is missing some information on a few caches. These are added in this PR. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Salva Corts	d421feafe6	Log when returning query-time limit (#8938) ... **What this PR does / why we need it**: At https://github.com/grafana/loki/pull/8727 we introduced various limits that can now be configured at query time. We always compare the value of the limit configured at query time with the value set on the overrides for the tenant or the default if not configured (aka original); applying the most restrictive one. If the most restrictive is the original value or the limit is not configured at query-time, we print the following debug message: 9e1846c47a/pkg/util/querylimits/limiter.go (L43) It will be printed many times: every time the query is not configured at query-time, as well as every time the original value is more restrictive. Moreover, this log message lacks some useful information such as the original value, the query-time value, the tenant ID and the limit name. This PR fixes this by removing the debug message above and printing a new debug message only if we return the query-time limit. This new log also prints the tenant ID, the limit name, as well as the original and the query-time limit values. **Which issue(s) this PR fixes**: Fixes https://github.com/grafana/loki/issues/8932 **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`	2 years ago
Karsten Jeschkies	038a7722d6	Ask users to add node types to the sizing tool. (#8834) ... **What this PR does / why we need it**: We want to invite users to make contributions to the node types of the sizing tool since we don't have the capacity to do so. **Checklist** - [ ] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: J Stickler <julie.stickler@grafana.com>	2 years ago
Travis Patterson	ee045312a9	Automatically Reorder Pipeline Filters (#8914) ... This PR moves Line Filters to be as early in a log pipeline as possible. For example: `{app="foo"} | logfmt |="some stuff"` becomes `{app="foo"} |="some stuff" | logfmt` Any LineFilter after a `LineFormat` stage will be moved to directly after the nearest `LineFormat` stage benchmarks: ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/pkg/logql/syntax cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz │ reorder_old.txt │ reorder_new.txt │ │ sec/op │ sec/op vs base │ ReorderedPipeline-8 2104.5n ± 3% 173.9n ± 2% -91.74% (p=0.000 n=10) │ reorder_old.txt │ reorder_new.txt │ │ B/op │ B/op vs base │ ReorderedPipeline-8 336.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=10) │ reorder_old.txt │ reorder_new.txt │ │ allocs/op │ allocs/op vs base │ ReorderedPipeline-8 16.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) ```	2 years ago
Periklis Tsirakidis	782ffca409	operator: Add missing replaces directives for release v0.2.0 (#8912)	2 years ago
Salva Corts	45775c82f7	Implement `RequiredNumberLabels` query limit (#8918) ... **What this PR does / why we need it**: As pointed out in https://github.com/grafana/loki/pull/8851, some queries can impose a great workload on a cluster by selecting too many streams. Similarly to the `RequiredLabels` limit introduced at https://github.com/grafana/loki/pull/8851, here we add a new limit `RequiredNumberLabels` to require queries to specify at least N label. For example, if the limit is set to 2, then the query should contain at least 2 label matchers. This limit can be configured per tenant and at query time.  **Which issue(s) this PR fixes**: Fixes https://github.com/grafana/loki-private/issues/699 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` --------- Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>	2 years ago
Periklis Tsirakidis	c81975bd9c	operator: Fix calculator dockerfile (#8931)	2 years ago
Michel Hollands	34486d4ba2	Change mention of 2.7.3 to 2.7.5 in Nomad (#8934) ... **What this PR does / why we need it**: Missed this in the previous PR. **Checklist** - [X] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Signed-off-by: Michel Hollands <michel.hollands@grafana.com>	2 years ago
Salva Corts	ee69f2bd37	Split index request in 24h intervals (#8909) ... **What this PR does / why we need it**: At https://github.com/grafana/loki/pull/8670, we applied a time split of 24h intervals to all index stats requests to enforce the `max_query_bytes_read` and `max_querier_bytes_read` limits. When the limit is surpassed, the following message get's displayed:  As can be seen, the reported bytes read by the query are not the same as those reported by Grafana in the lower right corner of the query editor. This is because: 1. The index stats request for enforcing the limit is split in subqueries of 24h. The other index stats rquest is not time split. 2. When enforcing the limit, we are not displaying the bytes in powers of 2, but powers of 10 ([see here][2]). I.e. 1KB is 1000B vs 1KiB is 1024B. This PR adds the same logic to all index stats requests so we also time split by 24 intervals all requests that hit the Index Stats API endpoint. We also use powers of 2 instead of 10 on the message when enforcing `max_query_bytes_read` and `max_querier_bytes_read`.  Note that the library we use under the hoot to print the bytes rounds up and down to the nearest integer ([see][3]); that's why we see 16GiB compared to the 15.5GB in the Grafana query editor. **Which issue(s) this PR fixes**: Fixes https://github.com/grafana/loki/issues/8910 **Special notes for your reviewer**: - I refactored the`newQuerySizeLimiter` function and the rest of the _Tripperwares_ in `rountrip.go` to reuse the new IndexStatsTripperware. So we configure the split-by-time middleware only once. **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` [1]: https://grafana.com/docs/loki/latest/api/#index-stats [2]: https://github.com/grafana/loki/blob/main/pkg/querier/queryrange/limits.go#L367-L368 [3]: https://github.com/dustin/go-humanize/blob/master/bytes.go#L75-L78	2 years ago
Grot (@grafanabot)	f6a3300f87	[CI/CD] Update yaml file `./production/helm/loki/Chart.yaml` (+1 other) (#8923) ... **Here is a summary of the updates contained in this PR:** *** Update attribute `$.appVersion` in yaml file `./production/helm/loki/Chart.yaml` to the following value: `2.7.5` *** Bump version of Helm Chart Add changelog entry to `./production/helm/loki/CHANGELOG.md` Re-generate docs Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>	2 years ago