prometheus

Commit Graph

Author	SHA1	Message	Date
Bartlomiej Plotka	af5a7d1078	Add Chunks* Iterator/Querier/Selector to storage interface. * Added Chunk versions of all iterating methods. It all starts in Querier/ChunkQuerier. The plan is that Storage will implement both chunked and samples. * Added Seek to chunks.Iterator interface for iterating over chunks. * Mock, NewTestSeries, SampleSeriesIterator and ChunkSeriesIterator are now available from storage package and reuses instead of being recreated in many places. NewConcreteSeries was created to replace concreteSeries. * NewMergeChunkQuerier was added; Both this and NewMergeQuerier are now using generigMergeQuerier to share the code. Generic code was added. * Both Compactor and block Querier use exactly the same iterators. (blockChunkSeriesSet). * Added some TODO for further simplifications in next PRs. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Jaga Santagostino	350f25eed3	changes from PR requests (#6880 ) Signed-off-by: Jaga Santagostino <jagasantagostino@gmail.com>	5 years ago
Bartlomiej Plotka	4d6f9b75e2	Merge pull request #6971 from prometheus/select-sorted storage: Removed SelectSorted method while maintaining logic; Simplified interface.	5 years ago
Bartlomiej Plotka	9d9c45588e	Addressed Goutham's review. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Bartlomiej Plotka	cd9516316a	Addressed Brian's comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Bartlomiej Plotka	fe802f29c9	storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet which rely on sorting. I found during work on https://github.com/prometheus/prometheus/pull/5882 that we do so many repetitions because of this, for not good reason. I think I found a good balance between convenience and readability with just one method. Smaller the interface = better. Also I don't know what TestSelectSorted was testing, but now it's testing sorting. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Björn Rabenstein	bc703b6456	Use `struct{}` as underlying type for context keys (#6965 ) This is an alternative to #6963. Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
coding3min	4dfbf328f2	[OpenStack SD] Add HypervisorID meta labels about id (#6962 ) Add extra meta labels which will be useful in the case Prometheus discovery hypervisor . Signed-off-by: pzqu <pzqu@qq.com> Co-authored-by: pzqu <pzqu@example.com>	5 years ago
Diana Payton	6ab413ab41	Docs: Update getting_started.md (#6955 ) * Update getting_started.md Signed-off-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>	5 years ago
Björn Rabenstein	6029fa0b1b	Merge pull request #6951 from prometheus/beorn7/tsdb tsdb: Do a full rollback upon commit error	5 years ago
beorn7	f6f4fd6556	tsdb: Do a full rollback upon commit error I think the previous behavior is problematic as it will leave `memSeries` around that still have `pendingCommit` set to `true`. The only case where this can happen in this code path is a failure to write to the WAL, in which case we are probably in trouble anyway. I believe, however, we should still try to do the right thing and do the full rollback. This will implicitly try to write to the WAL again, but this time without samples, which may even succeed. (But we propagate the previous error in any case.) This also adds `a.head.putSeriesBuffer(a.sampleSeries)` to Rollback, which was previously missing. Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
李国忠	261cbab8e9	remove Unused parameter 'reg' in wal.Open function (#6941 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Julien Pivotto	a17ddcf0f9	update vendor (#6936 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
johncming	df14bca643	tsdb: fix typo for wrong metric name (#6938 ) Signed-off-by: johncming <johncming@yahoo.com>	5 years ago
Julien Pivotto	5ddd1dcf0f	Fix panic when parsing varags (#6940 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Boyko	84b00564f4	API_V1: Extract time param parsing logic (#6860 ) * extract API time param parsing logic in a func Signed-off-by: blalov <boiskila@gmail.com>	5 years ago
Tobias Guggenmos	1dbd799354	PromQL: Fix regression tests (#6935 ) This PR fixes the regression tests for the issue fixed in #6931 . The reason for that is that all of the invalid queries that triggered the regression have become more or less valid syntax in #6933 (they might still fail typechecking). Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Brian Brazil	5da8990053	Log scrape append failures as debug rather than warn. (#6852 ) This is most likely due to an endpoint not producing valid metrics output, which we should treat the same as a failed scrape, and thus not spam the application logs with it. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Brian Brazil	44ad28dd5e	PromQL: Allow more keywords as metric names (#6933 ) * Allow more keywords as metric names * Add documentation about forbidden keywords Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
Brian Brazil	7164b58945	PromQL: Fix parser panic (#6931 ) Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>	5 years ago
beorn7	0193b746b1	Defer call to iso.closeAppend This is taken from #6918. Since we probably won't merge #6918 before the relase, we have to do this bit of it as it fixes an actual bug (iso.closeAppend is not called if the append fails because of an error logging to the WAL). Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
Hrishikesh Barman	d1c00bb7c2	Added GITHUB_RUN_ID for direct link to running workflow. (#6926 ) * Added prominfra docker image path. Signed-off-by: Hrishikesh Barman <plain.hrishikeshbman@gmail.com> * Added GITHUB_RUN_ID usage. Signed-off-by: Hrishikesh Barman <plain.hrishikeshbman@gmail.com>	5 years ago
Ganesh Vernekar	2cc32c332d	Log WAL replay duration Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Guangwen Feng	a128fc3534	Add unit tests in labels.go (#6921 ) * Add unit test for func Equal in labels.go * Add unit test for func Compare in labels.go Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>	5 years ago
李国忠	2bf4952049	remove Unused parameter 'sf' in calcTrendValue function (#6900 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Alex Gaganov	df92a00838	Expose EC2 instance lifecycle as label (#6914 ) Signed-off-by: Alex Gaganov <alex.gaganov@fiverr.com>	5 years ago
李国忠	52025bd7a9	[comments] change word ‘wheter’ to ‘whether’ (#6912 ) * [comments] change word ‘wheter’ to ‘whether’ Signed-off-by: fuling <fuling.lgz@alibaba-inc.com> * [comments] change word ‘wheter’ to ‘whether’ Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Julien Pivotto	c67f81937c	discovery: updateGroup should not create targets[poolKey] in the loop (#6903 ) We can assume that not all target groups are nil in normal scernarios, so we can create targets[poolKey] outside the loop. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	ed623f69e2	tsdb: don't allow ingesting empty labelsets (#6891 ) * tsdb: don't allow ingesting empty labelsets When we ingest an empty labelset in the head, further blocks can not be compacted, with the error: ``` level=error ts=2020-02-27T21:26:58.379Z caller=db.go:659 component=tsdb msg="compaction failed" err="persist head block: write compaction: add series: out-of-order series added with label set \"{}\" / prev: \"{}\"" ``` We should therefore reject those invalid empty labelsets upfront. This can be reproduced with the following: ``` cat << END > prometheus.yml scrape_configs: - job_name: 'prometheus' scrape_interval: 1s basic_auth: username: test password: test metric_relabel_configs: - regex: ".*" action: labeldrop static_configs: - targets: - 127.0.1.1:9090 END ./prometheus --storage.tsdb.min-block-duration=1m ``` And wait a few minutes. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	2051ae2e6a	Revert "Fix race condition in Rule manager.Update() function" This reverts commit `8b11d2cfb6`. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Björn Rabenstein	babadf13e8	Merge pull request #6899 from prometheus/beorn7/isolation Do not attempt isolation for appendID == 0	5 years ago
fuling	8b11d2cfb6	Fix race condition in Rule manager.Update() function Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
李国忠	3fff701b77	[comments] change word ‘dependencie’ to ‘dependencies’ (#6904 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
beorn7	d9af11e636	Do not attempt isolation for appendID == 0 Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
Simon Kirsten	45fbed94d6	React UI: Fixed data table for matrix always showing 1 as value (#6896 ) Signed-off-by: Simon Kirsten <1972314+skirsten@users.noreply.github.com> React UI: Fixed data table for matrix always showing 1 as value	5 years ago
Chris Marchbanks	0e78908407	Escape target selector for tooltip on targets page (#6892 ) This fixes an issue where the /new/targets page will not load when there are jobs with invalid CSS characters in them, such as the namespace/service/0 form used by the Prometheus Operator. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
Björn Rabenstein	d137cddd12	Merge pull request #6841 from prometheus/beorn7/isolation Port isolation from old TSDB PR	5 years ago
beorn7	7f30b0984d	Implement isolation This has been ported from https://github.com/prometheus/tsdb/pull/306. Original implementation by @brian-brazil, explained in detail in the 2nd half of this talk: https://promcon.io/2017-munich/talks/staleness-in-prometheus-2-0/ The implementation was then processed by @gouthamve into the PR linked above. Relevant slide deck: https://docs.google.com/presentation/d/1-ICg7PEmDHYcITykD2SR2xwg56Tzf4gr8zfz1OerY5Y/edit?usp=drivesdk Signed-off-by: beorn7 <beorn@grafana.com> Co-authored-by: Brian Brazil <brian.brazil@robustperception.io> Co-authored-by: Goutham Veeramachaneni <gouthamve@gmail.com>	5 years ago
beorn7	6b8181370f	Fix punctuation nits Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
LongKB	82f7ed208b	Remove some duplicated words (#6882 ) Signed-off-by: Pham Duc Hanh <hanhpd@fujitsu.com>	5 years ago
Peter Štibraný	1d396b96dc	Specify that returned samples must be ordered by timestamp. (#6877 ) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	5 years ago
李国忠	ddd4dcec19	[fix] ui: th to td (#6874 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Ben Kochie	65a19421a4	Update React vendoring (#6855 ) * Update React vendoring Update webpack-scripts to 3.4.0 * Fix security warning for `serialize-javascript`. Signed-off-by: Ben Kochie <superq@gmail.com> * Fix eslint errors. Signed-off-by: Ben Kochie <superq@gmail.com> * Update test snapshot. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Callum Styan	1518083168	Rw testability improvements (#6537 ) * Change createTimeseries to take values for number of series and number of samples per series. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Take num of samples to expect in expectSampleCount instead of array of samples. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add field to TestStorageClient to ignore samples sent waitgroup for potential tests where we don't care about delivery of all samples. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Fix up tests a little bit. Signed-off-by: Callum Styan <callumstyan@gmail.com>	5 years ago
Bartlomiej Plotka	c4e74e241f	Merge pull request #6744 from slrtbtfs/split_parser Split promql package into parser and engine	5 years ago
Tobias Guggenmos	a56a057dc9	Empty commit to trigger CI Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Mathilde Gilles	9b9c58aea8	[Consul] Add health label to metrics (#5313 ) Label metrics with the target health using consul's /health endpoint. Signed-off-by: Mathilde Gilles <m.gilles@criteo.com>	5 years ago
Tobias Guggenmos	3d74fcfa6a	Bartek's suggestions Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Julien Pivotto	202813a654	Merge pull request #6867 from pracucci/enhance-ulid-entropy-generator Use a cryptographically secure random generator for ULID	5 years ago
Bartlomiej Plotka	c869e046a5	Merge pull request #6840 from pstibrany/context_from_request_should_not_return_error Don't return error in ContextFromRequest function.	5 years ago

1 2 3 4 5 ...

7652 Commits (add-chunkiterator-interface) All Branches Search

7652 Commits (add-chunkiterator-interface)

All Branches