prometheus

Commit Graph

Author	SHA1	Message	Date
Bartlomiej Plotka	aa0f00efdf	tests(teststorage, api_test): Fix leaking readers; kill fake exemplar storage (#17906 ) * tests(teststorage): Fix leaking readers; use TSDB exemplar storage instead of fake Signed-off-by: bwplotka <bwplotka@gmail.com> * switched to v1 exemplar flow for now Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	4 months ago
George Krajcsovits	d25c8476e7	chore(sd-ownership): add default-maintainers as default code owner (#17940 ) * chore(sd-ownership): add default-maintainers as default code owner In accordance with dev summit decision. At the same time I've set up auto assignment for code review, meaning that not everybody will get notified for all PRs. If there's already a maintainer assigned, you don't get notified. Otherwise the assignment is round-robin, 1 at a time. Also you can opt out. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Remove code owner without write access Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	4 months ago
Arve Knudsen	a5f86c3fb6	cmd/prometheus: fix flaky TestQueryLog race condition (#17933 ) Add waitForQueryLog helper that polls for query log entries to appear before asserting, rather than reading the file immediately after making a query. This fixes a race condition where the query log wasn't flushed to disk before the test read the file. The helper uses a 5 second timeout with 100ms polling intervals, which is generous enough to handle slow CI environments while keeping the test responsive. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 months ago
Aditya Prakash	5e66c9305f	scrape: clarify test channel name in manager_test (#17929 ) Signed-off-by: Nova <adityaprakash1357908@gmail.com>	4 months ago
Ganesh Vernekar	9eb78735cf	Merge pull request #16929 from prometheus/codesome/stale-series-compaction tsdb: Early compaction of stale series Closes #13616 Based on https://github.com/prometheus/proposals/pull/55 Stale series tracking was added in #16925. This PR compacts the stale series into its own block before the normal compaction hits. Here is how the settings: stale_series_compaction_threshold: As soon as the ratio of stale series in the head block crosses StaleSeriesImmediateCompactionThreshold, TSDB performs a stale series compaction and puts all the stale series into a block and removed it from the head, but it does not remove it from the WAL. (technically this condition is checked every minute and not exactly immediate) Additional details WAL replay: after a stale series compaction, tombstones are added with (MinInt64, MaxInt64) for all these stale series. During WAL replay we add a special condition where when we find such tombstone, it immediately removes the series from the memory instead of storing the tombstone. This is required so that we don't spike up memory during WAL replay and also don't keep the compacted stale series in the memory. Head block truncation ignores this block via the added metadata, similar to out-of-order blocks.	4 months ago
Arve Knudsen	2332962c4b	otlptranslator: filter __name__ from OTLP attributes to prevent duplicates (#17917 ) * otlptranslator: filter __name__ from OTLP attributes to prevent duplicates OTLP metrics can have a __name__ attribute which, when combined with the metric name passed via extras, creates duplicate __name__ labels. This commit implements filtering out of any __name__ metric attribute from OTLP. Also rename TestCreateAttributes to TestPrometheusConverter_createAttributes for consistency, and add test cases for __name__, __type__, and __unit__ OTLP metric attributes. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 months ago
Ganesh Vernekar	3e4a094dbb	Add stale_series_compaction_threshold config file option Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	4 months ago
Ganesh Vernekar	4f3de8da29	tsdb: Add unit tests for stale series compaction Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	4 months ago
Ganesh Vernekar	43dc23afe7	tsdb: Clear stale series from the Head during WAL replay Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	4 months ago
Ganesh Vernekar	43e69388df	tsdb: Add stale series compaction support in the DB Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	4 months ago
Ganesh Vernekar	9b444b57af	tsdb: Add StaleHead and GC for stale series in the Head block Signed-off-by: Ganesh Vernekar <ganesh.vernekar@reddit.com>	4 months ago
Bartlomiej Plotka	bec70227f1	feat(scrape)[PART5b]: Add AppenderV2 support to scrape.NewManager constructor (#17872 ) * feat(scrape)[PART5b]: Add AppenderV2 support to scrape.NewManager optionally to V1 Signed-off-by: bwplotka <bwplotka@gmail.com> * Update scrape/manager.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * fixes after rebase Signed-off-by: bwplotka <bwplotka@gmail.com> * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	4 months ago
Bartlomiej Plotka	0d116b0994	tests(teststorage): Close Storage in the helper (#17902 ) Signed-off-by: bwplotka <bwplotka@gmail.com>	4 months ago
Siavash Safi	2437977bff	fix(notify): apply config sendloop cleanup fix (#17915 ) These bugs were discovered accidentally with code analysis: - https://app.devin.ai/review/prometheus/prometheus/pull/16355 Upon further inspection and performing more analysis, 3 potential bugs were found: 1. sendloops could continue running if corresponding AM changed position in the config 2. multiple configs with the same hash would share sendloops resulting in sets without sendloops 3. sendloops could continue running if the config hash was changed - `TestApplyConfigSendLoopsNotStoppedOnKeyChange`: Verifies sendLoops work when keys swap (no fix needed) - `TestApplyConfigDuplicateHashSharesSendLoops`: Verifies sendLoops are independent with duplicate hashes (bug fixed) - `TestApplyConfigHashChangeLeaksSendLoops`: Verifies sendLoops are cleaned up when hash changes (bug fixed) Signed-off-by: Siavash Safi <siavash@cloudflare.com>	4 months ago
Ben Kochie	2a890d6fcf	Bump promci action (#17912 ) Update promci to pick up `latest` tag fix. Fixes: https://github.com/prometheus/prometheus/issues/16238 Signed-off-by: SuperQ <superq@gmail.com>	4 months ago
Ben Kochie	9b549fa118	Update Go yaml v3 library (#17913 ) Replace archived `gopkg.in/yaml.v3` with supported `go.yaml.in/yaml/v3`. Fixes: https://github.com/prometheus/prometheus/issues/16415 Signed-off-by: SuperQ <superq@gmail.com>	4 months ago
zenador	9a49316c59	promql: info function: fix unit test for ignoring info metrics themselves (#17911 ) Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	4 months ago
Björn Rabenstein	82fec75982	Merge pull request #17626 from aviralgarg05/fix-promqltest-counter-reset-hint-comparison promqltest: Add optional counter reset hint comparison for native histograms	4 months ago
Siavash Safi	d9ccd70ac1	fix(notify): flaky tests (#17899 ) Add a helper function to set up AlertmanagerSets. Fix all flaky tests. Signed-off-by: Siavash Safi <siavash@cloudflare.com>	4 months ago
Julien	8e6b097560	Merge pull request #17892 from roidelapluie/roidelapluie/pushver Makefile.common: Push major version tags to registry	4 months ago
Matt	39e524088c	Fix(discovery/aws): Create Copies of Default Config (#17769 ) Signed-off-by: matt-gp <small_minority@hotmail.com>	4 months ago
George Krajcsovits	21fb899c32	fix(teststorage/appender.go): TODO and Sample staleness check (#17905 ) * fix(teststorage/appender.go): TODO and Sample staleness check Allow different order of consecutive stale samples between the expected and actual array for RequireEqual and RequireNotEqual by trying to swap the expected side until it matches. Also fix the definition of stale sample in the test, it's not only float, but defined for native histograms as well. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * add unit tests Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	4 months ago
Bartlomiej Plotka	04a3ef75f2	chore: remove testutil.T which is no longer needed since Go 1.13 (#17903 ) testutil.T was needed before https://go.dev/doc/go1.13#testingpkgtesting Now it's inconsistent and confusing, so let's kill it. Signed-off-by: bwplotka <bwplotka@gmail.com>	4 months ago
Bartlomiej Plotka	664b255699	Merge pull request #17867 from prometheus/bwplotka/a2-scrape-1 refactor(appenderV2)[PART5a]: add AppendableV2 support to scrape loop + tests	4 months ago
zenador	e3b6eee437	promql: info function: fix series without identifying labels not being returned (#17898 ) * promql: info function: fix series without identifying labels not being returned --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	4 months ago
Bartlomiej Plotka	c021f316ba	Merge pull request #17897 from roidelapluie/roidelapluie/gowork Align go.work version with go.mod files	4 months ago
Julien Pivotto	6b3867e8d4	Align go.work version with go.mod files Update go.work from go 1.24.9 to go 1.24.0 to match the version specified in all go.mod files across the project Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	4 months ago
Bryan Boreham	d83e11926d	Merge pull request #17795 from chuanye-gao/fix/ready-stopping-header-test web: fix /-/ready stopping header and add tests	4 months ago
Bartlomiej Plotka	bc55334845	Merge pull request #17881 from bboreham/scrape-benchmark [TESTS] Scraping: Reset appender in BenchmarkScrapeLoopAppend	4 months ago
Julien	2193782b1d	Merge pull request #17826 from roidelapluie/roidelapluie/goworkversion scripts: use git ls-files and check go.work files in version check	4 months ago
Julien	d63e418d78	Merge pull request #17896 from roidelapluie/roidelapluie/fixdistroless Fix ARG scoping in Dockerfile.distroless	4 months ago
Bryan Boreham	853572c1bf	Merge pull request #17830 from hritz220/util/strutil-enhance-test-coverage util: enhance test coverage for strutil package	4 months ago
Julien Pivotto	3733a14b87	Fix ARG scoping in Dockerfile.distroless ARG declarations before FROM are only available within the FROM instruction and go out of scope afterward. Re-declare ARCH and OS after FROM so they're available for the COPY instructions. This fixes the build failure where ${OS}-${ARCH} resolved to empty strings, causing "not found" errors for .build/-/prometheus. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	4 months ago
wangyazhou	629bd3c5d5	Fix logger syntax for timingsLogger (#17870 ) Fix logger syntax for timingsLogger Signed-off-by: wangyazhou <564631192@qq.com>	4 months ago
yy	0e77dcfdb9	fix: typo in error message (#17878 ) Signed-off-by: Yohei Yamamoto <yhymmt123@gmail.com>	4 months ago
Julien	3c532e14de	Merge pull request #17893 from roidelapluie/roidelapluie/distrolessarch Fix multi-arch support for distroless Docker image	4 months ago
Siavash Safi	a89c665f47	feat(notifier): independent alertmanager sendloops (#16355 ) * notifier: unit test for dropping throughput on stuck AM Ref: https://github.com/prometheus/prometheus/issues/7676 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: Siavash Safi <siavash@cloudflare.com> * chore(notifier): remove year from copyrights Signed-off-by: Siavash Safi <siavash@cloudflare.com> * feat(notifier): independent alertmanager sendloops Independent Alertmanager sendloops avoid issues with queue overflowing when one or more Alertmanager instances are unavailable which could result in lost alert notifications. The sendloops are managed per AlertmanagerSet which are dynamically added/removed with service discovery or configuration reload. The following metrics now include an extra dimention for alertmanager label: - prometheus_notifications_dropped_total - prometheus_notifications_queue_capacity - prometheus_notifications_queue_length This change also includes the test from #14099 Closes #7676 Signed-off-by: machine424 <ayoubmrini424@gmail.com> Signed-off-by: Siavash Safi <siavash@cloudflare.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: Siavash Safi <siavash@cloudflare.com> Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	4 months ago
Ben Kochie	1a0c56993c	Use standard library errors in otlptranslator (#17894 ) Remove direct use of `go.uber.org/multierr` in favor of standard library `errors` package. Signed-off-by: SuperQ <superq@gmail.com>	4 months ago
Julius Volz	1d3d98ed16	Merge pull request #17644 from prometheus/binop-fill-modifier PromQL: Add `fill*()` binop modifiers to provide default values for missing series	4 months ago
Julien Pivotto	01637b47b0	Fix multi-arch support for distroless Docker image The distroless Dockerfile was using a hardcoded SHA256 digest that referenced only the amd64 image, preventing builds for other architectures. This caused the main-distroless tag to only publish amd64 images while the regular main tag had all 5 architectures. Changes: - Use architecture-specific image tags (nonroot-${DISTROLESS_ARCH}) instead of SHA256 digest to enable multi-arch manifest resolution - Add DISTROLESS_ARCH build arg to handle architecture name mapping (armv7 -> arm) between Prometheus and distroless conventions - Move ARG declarations before FROM to support variable substitution Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	4 months ago
Julien Pivotto	adaf139826	Makefile.common: Push major version tags to registry In commit `74775d732` "Add major version tag (#8026)" from 2020, the docker-tag-latest target was updated to create major version tags (v2, v3, etc.) but these tags were never actually pushed to the registry. They existed locally only after tagging but were never published. This commit fixes the issue by: - Adding logic to docker-publish to push major version tags when DOCKER_IMAGE_TAG="latest" (triggered by promci during releases) - Adding logic to docker-manifest to create major version manifests when DOCKER_IMAGE_TAG="latest" Pre-release filtering is handled at the promci level, where the regex check ^v[0-9]+(\.[0-9]+){2}$ already ensures only stable releases trigger the "latest" tagging workflow. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	4 months ago
Julien	716003851d	Merge pull request #17876 from roidelapluie/roidelapluie/distroless Add distroless Docker image variant	4 months ago
Julien Pivotto	1105c825cf	Add distroless Docker image variant Introduces distroless image using UID/GID 65532 instead of nobody, and removes VOLUME declaration. Busybox image remains default with unchanged tags for backwards compatibility. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	4 months ago
Arve Knudsen	572f247b4d	tsdb: add auto-cleanup to newTestHead and remove redundant cleanup calls (#17890 ) Add automatic cleanup to newTestHeadWithOptions so that heads created with newTestHead are automatically closed when the test ends. This simplifies test code by removing the need for manual cleanup in most cases. Changes: - Add t.Cleanup in newTestHeadWithOptions immediately after creating the head, using _ = h.Close() to handle double-close gracefully - Remove redundant t.Cleanup, defer, and explicit Close calls from tests that use newTestHead - Add cleanup for heads created with NewHead directly in restart patterns (e.g., restartHeadAndVerifySeriesCounts, startHead) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 months ago
Arve Knudsen	dd85d7ca97	tsdb: fix memory leaks in buffer pools (#17879 ) * tsdb: fix memory leaks in buffer pools Clear reference fields when returning buffers to pools to avoid retaining data after the buffer is reused. Affected pools: - refSeriesPool: clear Labels - histogramsPool: clear H pointer - floatHistogramsPool: clear FH pointer - metadataPool: clear Unit and Help strings Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Clear slices Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Clear metadata buffer Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 months ago
Bryan Boreham	2dec6da3d1	[TESTS] Scraping: Reset appender in BenchmarkScrapeLoopAppend Otherwise performance is dominated by adding to a slice that gets longer and longer as the benchmark progresses. I chose to Rollback rather than Commit because that should do less work. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	4 months ago
Julius Volz	90dbdcd5dc	Fix a missing space/newline in the binop docs Signed-off-by: Julius Volz <julius.volz@gmail.com>	4 months ago
Julius Volz	05440ffc3b	Add a few fill modifier tests with keyword-like metric names Signed-off-by: Julius Volz <julius.volz@gmail.com>	4 months ago
Bartlomiej Plotka	c4b0da94db	Merge pull request #17835 from prometheus/bwplotka/a2-storage-support feat(storage)[PART4b]: add AppenderV2 to the rest of storage.Storage implementations + mock exemplar fix	4 months ago
Julien	c7f92054fc	Merge pull request #17871 from roidelapluie/roidelapluie/fix-fuzzing-issues fuzzing: fix artifact path and experimental parser flags	4 months ago

1 2 3 4 5 ...

16811 Commits (aa0f00efdf7fc4c2ca0982063fdd031f95d7b79b) All Branches Search

16811 Commits (aa0f00efdf7fc4c2ca0982063fdd031f95d7b79b)

All Branches