Run coding standards auto-fixes (#5085)

pull/5070/head^2^2
Marco Villegas 2 years ago committed by GitHub
parent 7d6ddd0f28
commit 6393ab9c8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      src/CoreBundle/Controller/SocialController.php
  2. 7
      src/CoreBundle/Entity/GradebookCategory.php
  3. 3
      src/CoreBundle/Entity/Session.php
  4. 4
      src/CoreBundle/Form/JuryType.php
  5. 2
      src/CoreBundle/Migrations/Schema/V200/Version20230508153435.php
  6. 2
      src/CoreBundle/Migrations/Schema/V200/Version20240114174300.php
  7. 4
      src/CoreBundle/Migrations/Schema/V200/Version20240114212100.php
  8. 2
      src/CoreBundle/Repository/BranchSyncRepository.php
  9. 2
      src/CourseBundle/Entity/CForumCategory.php
  10. 4
      tests/CoreBundle/Repository/SessionRepositoryTest.php

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1); declare(strict_types=1);
/* For licensing terms, see /license.txt */ /* For licensing terms, see /license.txt */
@ -6,14 +7,12 @@ declare(strict_types=1);
namespace Chamilo\CoreBundle\Controller; namespace Chamilo\CoreBundle\Controller;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\JsonResponse; use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Routing\Annotation\Route; use Symfony\Component\Routing\Annotation\Route;
#[Route('/social')] #[Route('/social')]
class SocialController extends AbstractController class SocialController extends AbstractController
{ {
#[Route('/personal-data', name: 'chamilo_core_social_personal_data')] #[Route('/personal-data', name: 'chamilo_core_social_personal_data')]
public function getPersonalData(): JsonResponse public function getPersonalData(): JsonResponse
{ {

@ -35,7 +35,6 @@ use Symfony\Component\Validator\Constraints as Assert;
#[ApiFilter(SearchFilter::class, properties: [ #[ApiFilter(SearchFilter::class, properties: [
'course' => 'exact', 'course' => 'exact',
])] ])]
class GradebookCategory class GradebookCategory
{ {
use CourseTrait; use CourseTrait;
@ -45,7 +44,6 @@ class GradebookCategory
#[ORM\Id] #[ORM\Id]
#[ORM\GeneratedValue] #[ORM\GeneratedValue]
#[Groups(['document:read', 'gradebookCategory:read'])] #[Groups(['document:read', 'gradebookCategory:read'])]
protected ?int $id = null; protected ?int $id = null;
#[Assert\NotBlank] #[Assert\NotBlank]
@ -62,7 +60,6 @@ class GradebookCategory
#[ORM\ManyToOne(targetEntity: Course::class, inversedBy: 'gradebookCategories')] #[ORM\ManyToOne(targetEntity: Course::class, inversedBy: 'gradebookCategories')]
#[ORM\JoinColumn(name: 'c_id', referencedColumnName: 'id', onDelete: 'CASCADE')] #[ORM\JoinColumn(name: 'c_id', referencedColumnName: 'id', onDelete: 'CASCADE')]
#[Groups(['gradebookCategory:read'])] #[Groups(['gradebookCategory:read'])]
protected Course $course; protected Course $course;
#[ORM\ManyToOne(targetEntity: self::class, inversedBy: 'subCategories')] #[ORM\ManyToOne(targetEntity: self::class, inversedBy: 'subCategories')]
@ -119,7 +116,7 @@ class GradebookCategory
protected ?int $certifMinScore = null; protected ?int $certifMinScore = null;
#[ORM\OneToOne(inversedBy: 'gradebookCategory', targetEntity: CDocument::class)] #[ORM\OneToOne(inversedBy: 'gradebookCategory', targetEntity: CDocument::class)]
#[ORM\JoinColumn(name: 'document_id', referencedColumnName: 'iid', onDelete: "set null")] #[ORM\JoinColumn(name: 'document_id', referencedColumnName: 'iid', onDelete: 'set null')]
#[ApiSubresource] #[ApiSubresource]
#[Groups(['gradebookCategory:read', 'gradebookCategory:write'])] #[Groups(['gradebookCategory:read', 'gradebookCategory:write'])]
protected ?CDocument $document = null; protected ?CDocument $document = null;
@ -252,6 +249,8 @@ class GradebookCategory
/** /**
* Set documentId. * Set documentId.
* *
* @param mixed $document
*
* @return GradebookCategory * @return GradebookCategory
*/ */
public function setDocument($document) public function setDocument($document)

@ -46,7 +46,6 @@ use Symfony\Component\Validator\Constraints as Assert;
denormalizationContext: ['groups' => ['session:write']], denormalizationContext: ['groups' => ['session:write']],
security: "is_granted('ROLE_ADMIN')" security: "is_granted('ROLE_ADMIN')"
)] )]
#[ORM\Table(name: 'session')] #[ORM\Table(name: 'session')]
#[ORM\UniqueConstraint(name: 'title', columns: ['title'])] #[ORM\UniqueConstraint(name: 'title', columns: ['title'])]
#[ORM\EntityListeners([SessionListener::class])] #[ORM\EntityListeners([SessionListener::class])]
@ -55,7 +54,7 @@ use Symfony\Component\Validator\Constraints as Assert;
#[ApiFilter(filterClass: SearchFilter::class, properties: ['title' => 'partial'])] #[ApiFilter(filterClass: SearchFilter::class, properties: ['title' => 'partial'])]
#[ApiFilter(filterClass: PropertyFilter::class)] #[ApiFilter(filterClass: PropertyFilter::class)]
#[ApiFilter(filterClass: OrderFilter::class, properties: ['id', 'title'])] #[ApiFilter(filterClass: OrderFilter::class, properties: ['id', 'title'])]
class Session implements ResourceWithAccessUrlInterface, \Stringable class Session implements ResourceWithAccessUrlInterface, Stringable
{ {
public const VISIBLE = 1; public const VISIBLE = 1;
public const READ_ONLY = 2; public const READ_ONLY = 2;

@ -47,8 +47,8 @@ class JuryType extends AbstractType
'property' => 'title', 'property' => 'title',
'query_builder' => function (EntityRepository $er) { 'query_builder' => function (EntityRepository $er) {
return $er->createQueryBuilder('u') return $er->createQueryBuilder('u')
//->where('u.role LIKE :role') // ->where('u.role LIKE :role')
//->setParameter(':role', 'ROLE_JURY%') // ->setParameter(':role', 'ROLE_JURY%')
->orderBy('u.title', Criteria::DESC) ->orderBy('u.title', Criteria::DESC)
; ;
}, },

@ -232,7 +232,6 @@ final class Version20230508153435 extends AbstractMigrationChamilo
); );
} }
if ($schema->hasTable('specific_field')) { if ($schema->hasTable('specific_field')) {
$this->addSql( $this->addSql(
'ALTER TABLE specific_field CHANGE name title VARCHAR(200) NOT NULL' 'ALTER TABLE specific_field CHANGE name title VARCHAR(200) NOT NULL'
@ -310,7 +309,6 @@ final class Version20230508153435 extends AbstractMigrationChamilo
'ALTER TABLE skill_level_profile CHANGE name title VARCHAR(255) NOT NULL' 'ALTER TABLE skill_level_profile CHANGE name title VARCHAR(255) NOT NULL'
); );
} }
} }
public function down(Schema $schema): void public function down(Schema $schema): void

@ -90,12 +90,10 @@ final class Version20240114174300 extends AbstractMigrationChamilo
'ALTER TABLE lti_external_tool CHANGE name title VARCHAR(255) NOT NULL' 'ALTER TABLE lti_external_tool CHANGE name title VARCHAR(255) NOT NULL'
); );
} }
} }
public function down(Schema $schema): void public function down(Schema $schema): void
{ {
$table = $schema->getTable('lti_external_tool'); $table = $schema->getTable('lti_external_tool');
if ($table->hasColumn('title')) { if ($table->hasColumn('title')) {
$this->addSql('ALTER TABLE lti_external_tool CHANGE title name VARCHAR(255) NOT NULL'); $this->addSql('ALTER TABLE lti_external_tool CHANGE title name VARCHAR(255) NOT NULL');

@ -16,7 +16,6 @@ final class Version20240114212100 extends AbstractMigrationChamilo
public function up(Schema $schema): void public function up(Schema $schema): void
{ {
if ($schema->hasTable('contact_form_contact_category')) { if ($schema->hasTable('contact_form_contact_category')) {
$this->addSql( $this->addSql(
'ALTER TABLE contact_form_contact_category CHANGE name title VARCHAR(255) NOT NULL' 'ALTER TABLE contact_form_contact_category CHANGE name title VARCHAR(255) NOT NULL'
@ -43,12 +42,10 @@ final class Version20240114212100 extends AbstractMigrationChamilo
'ALTER TABLE fos_group CHANGE name title VARCHAR(255) NOT NULL' 'ALTER TABLE fos_group CHANGE name title VARCHAR(255) NOT NULL'
); );
} }
} }
public function down(Schema $schema): void public function down(Schema $schema): void
{ {
$table = $schema->getTable('resource_file'); $table = $schema->getTable('resource_file');
if ($table->hasColumn('title')) { if ($table->hasColumn('title')) {
$this->addSql('ALTER TABLE resource_file CHANGE title name VARCHAR(255) NOT NULL'); $this->addSql('ALTER TABLE resource_file CHANGE title name VARCHAR(255) NOT NULL');
@ -71,6 +68,5 @@ final class Version20240114212100 extends AbstractMigrationChamilo
if ($table->hasColumn('title')) { if ($table->hasColumn('title')) {
$this->addSql('ALTER TABLE contact_form_contact_category CHANGE title name VARCHAR(255) NOT NULL'); $this->addSql('ALTER TABLE contact_form_contact_category CHANGE title name VARCHAR(255) NOT NULL');
} }
} }
} }

@ -39,7 +39,7 @@ class BranchSyncRepository extends ServiceEntityRepository
// Selecting courses for users // Selecting courses for users
// $qb->innerJoin('u.courses', 'c'); // $qb->innerJoin('u.courses', 'c');
//@todo check app settings // @todo check app settings
$qb->addOrderBy('b.title', 'ASC'); $qb->addOrderBy('b.title', 'ASC');
$qb->where('b.title LIKE :keyword'); $qb->where('b.title LIKE :keyword');
$qb->setParameter('keyword', "%$keyword%", Types::STRING); $qb->setParameter('keyword', "%$keyword%", Types::STRING);

@ -71,8 +71,6 @@ class CForumCategory extends AbstractResource implements ResourceInterface, Stri
/** /**
* Get title. * Get title.
*
* @return string
*/ */
public function getTitle(): string public function getTitle(): string
{ {

@ -500,7 +500,7 @@ class SessionRepositoryTest extends AbstractApiTest
$this->assertNotNull($category->getDateEnd()); $this->assertNotNull($category->getDateEnd());
$this->assertNotNull($category->getUrl()); $this->assertNotNull($category->getUrl());
$session = ($sessionRepo->create()) $session = $sessionRepo->create()
->setTitle('session 1') ->setTitle('session 1')
->addGeneralCoach($coach) ->addGeneralCoach($coach)
->addAccessUrl($url) ->addAccessUrl($url)
@ -549,7 +549,7 @@ class SessionRepositoryTest extends AbstractApiTest
$coach = $this->createUser('coach'); $coach = $this->createUser('coach');
$course = $this->createCourse('new'); $course = $this->createCourse('new');
$session = ($sessionRepo->create()) $session = $sessionRepo->create()
->setTitle('session 1') ->setTitle('session 1')
->addGeneralCoach($coach) ->addGeneralCoach($coach)
->addAccessUrl($url) ->addAccessUrl($url)

Loading…
Cancel
Save